-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: vm: support raw blocks in chain export #8691
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need this for NV16 to include code in chain snapshots. NOTE: I've also checked the splitstore, and we appear to be doing the right thing there already.
Stebalien
force-pushed
the
fix/support-raw-export
branch
from
May 20, 2022 22:56
baee6e3
to
f491e39
Compare
12 tasks
Codecov Report
@@ Coverage Diff @@
## master #8691 +/- ##
==========================================
+ Coverage 40.85% 40.88% +0.02%
==========================================
Files 687 687
Lines 75840 75845 +5
==========================================
+ Hits 30987 31007 +20
+ Misses 39517 39491 -26
- Partials 5336 5347 +11
|
vyzo
approved these changes
May 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to cherry pick this for the nv16 branch.
raulk
approved these changes
May 21, 2022
arajasek
approved these changes
May 23, 2022
magik6k
approved these changes
May 23, 2022
5 tasks
5 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes
Support raw blocks in chain export. We now visit them, we just don't recurs on them.
We need this for NV16 to include code in chain snapshots.
NOTE: I've also checked the splitstore, and we appear to be doing the right thing there already.
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, testarea
: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps