feat: worker: lotus-worker run --no-default

[magik6k]

Related Issues

Proposed Changes

lotus-worker has gained quite a lot of task-type flags, most of which are opt-out, which is a bit annoying, especially when creating storage-only workers. This PR adds a new flag which makes compute tasks opt-in instead of opt-out:

PreCommit1 worker before:

./lotus-worker run --precommit2=false --commit=false --prove-replica-update2=false --replica-update=false

PreCommit1 worker after:

./lotus-worker run --no-default --precommit1

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

• All commits have a clear commit message.
• The PR title is in the form of of <PR type>: <area>: <change being made>
  • example: fix: mempool: Introduce a cache for valid signatures
  • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
  • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
• This PR has tests for new functionality or change in behaviour
• If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
• CI is green

[codecov]

Codecov Report

Merging #8672 (6b3bc8c) into master (33a05d3) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

❗ Current head 6b3bc8c differs from pull request most recent head abf8316. Consider uploading reports for the commit abf8316 to get more accurate results

@@            Coverage Diff             @@
##           master    #8672      +/-   ##
==========================================
- Coverage   40.94%   40.82%   -0.12%     
==========================================
  Files         686      686              
  Lines       75750    75753       +3     
==========================================
- Hits        31017    30928      -89     
- Misses      39394    39481      +87     
- Partials     5339     5344       +5     

Impacted Files	Coverage Δ
cmd/lotus-worker/main.go	0.00% <0.00%> (ø)
itests/kit/blockminer.go	69.02% <0.00%> (-20.66%)	⬇️
storage/wdpost_sched.go	75.49% <0.00%> (-9.81%)	⬇️
cli/util.go	70.83% <0.00%> (-8.34%)	⬇️
extern/sector-storage/worker_tracked.go	80.50% <0.00%> (-6.78%)	⬇️
miner/miner.go	57.04% <0.00%> (-3.61%)	⬇️
chain/stmgr/call.go	69.18% <0.00%> (-3.25%)	⬇️
chain/stmgr/searchwait.go	67.30% <0.00%> (-2.57%)	⬇️
chain/sub/incoming.go	59.02% <0.00%> (-2.45%)	⬇️
node/impl/full/mpool.go	46.95% <0.00%> (-1.74%)	⬇️
... and 13 more

[RobQuistNL]

This is not going to work because if you use dedicated AP machines the PC1 will still need to do a Fetch - this will deadlock the job flow.

I've modified it before to always by default use Fetch (but excluded the other defaults from workers)

[magik6k]

You should see fetch on workers with --no-default, we add it here: https://github.com/filecoin-project/lotus/pull/8672/files#diff-f711d6c89c998547913cc59960c1b32609adebd6800ff9b7589d5ac5bf459614R315

[RobQuistNL]

Aaah I misread. This just disables all the extra flags after it. I thought you disabled all the other defaults too, my bad 👍