Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make markets logger less noisy when doing retrievals #8604

Merged
merged 1 commit into from
May 5, 2022

Conversation

RobQuistNL
Copy link
Contributor

@RobQuistNL RobQuistNL commented May 5, 2022

Logging each block causes a lot of useless information in the logs

Proposed Changes

Log all events as info, except for block transfers, which will be debug

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

Logging each block causes a lot of useless information in the logs
@RobQuistNL RobQuistNL requested a review from a team as a code owner May 5, 2022 09:57
@RobQuistNL RobQuistNL changed the title fix: Make markets logger less noise when doing retrievals fix: Make markets logger less noisy when doing retrievals May 5, 2022
@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #8604 (767a53f) into master (d8f1380) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8604      +/-   ##
==========================================
- Coverage   40.89%   40.83%   -0.07%     
==========================================
  Files         686      686              
  Lines       75710    75716       +6     
==========================================
- Hits        30961    30917      -44     
- Misses      39420    39465      +45     
- Partials     5329     5334       +5     
Impacted Files Coverage Δ
markets/loggers/loggers.go 91.17% <100.00%> (+1.89%) ⬆️
itests/kit/blockminer.go 70.65% <0.00%> (-19.03%) ⬇️
chain/events/observer.go 73.79% <0.00%> (-6.21%) ⬇️
chain/exchange/peer_tracker.go 66.66% <0.00%> (-4.31%) ⬇️
storage/wdpost_sched.go 79.41% <0.00%> (-3.93%) ⬇️
chain/sub/incoming.go 59.02% <0.00%> (-2.45%) ⬇️
node/impl/full/mpool.go 46.95% <0.00%> (-1.74%) ⬇️
chain/stmgr/stmgr.go 63.00% <0.00%> (-0.50%) ⬇️
markets/storageadapter/dealpublisher.go 82.03% <0.00%> (-0.49%) ⬇️
chain/consensus/filcns/filecoin.go 52.17% <0.00%> (-0.44%) ⬇️
... and 12 more

@magik6k magik6k merged commit 3184eb9 into filecoin-project:master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants