Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lotus-wallet: correct network in version #8563

Merged
merged 1 commit into from
May 4, 2022

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Apr 28, 2022

Adding $(GOFLAGS) so that when compiling lotus-wallet on calibnet, the correct network is shown, instead of showing just lotus-wallet version x.xx.x+mainnet. Should address 2. in #8459

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

Adding $(GOFLAGS) so that when compiling on calibnet, the correct network is shown, instead of showing just `mainnet`. Should address 2. in #8459
@rjan90 rjan90 requested a review from a team as a code owner April 28, 2022 08:12
@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #8563 (04bb539) into master (1162b02) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8563      +/-   ##
==========================================
- Coverage   40.83%   40.76%   -0.08%     
==========================================
  Files         686      686              
  Lines       75587    75587              
==========================================
- Hits        30867    30810      -57     
- Misses      39391    39446      +55     
- Partials     5329     5331       +2     
Impacted Files Coverage Δ
itests/kit/blockminer.go 70.10% <0.00%> (-19.57%) ⬇️
chain/sub/incoming.go 58.10% <0.00%> (-2.45%) ⬇️
chain/events/events_called.go 85.85% <0.00%> (-2.44%) ⬇️
storage/wdpost_sched.go 79.41% <0.00%> (-1.97%) ⬇️
extern/storage-sealing/currentdealinfo.go 70.17% <0.00%> (-1.76%) ⬇️
node/impl/full/mpool.go 46.95% <0.00%> (-1.74%) ⬇️
miner/miner.go 55.73% <0.00%> (-1.64%) ⬇️
chain/stmgr/searchwait.go 67.30% <0.00%> (-1.29%) ⬇️
extern/sector-storage/sched.go 85.93% <0.00%> (-0.77%) ⬇️
chain/store/store.go 64.33% <0.00%> (-0.67%) ⬇️
... and 12 more

@arajasek arajasek merged commit 0de1b84 into master May 4, 2022
@arajasek arajasek deleted the fix/lotus-wallet-version branch May 4, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants