fix: worker: Download proofs if PRU2 is enabled #8552
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the `lotus-wallet run` to include that a `FULLNODE_API_INFO` env variable needs to be set before running
Currently the lotus-worker does not check or download the params if SnapDeal tasks are enabled, meaning that you get an param-error if you for example a run a new 'PC1 / RU / PRU2' worker and a SnapDeal gets assigned to it. Reported in #8549.
Codecov Report
@@ Coverage Diff @@
## master #8552 +/- ##
==========================================
- Coverage 40.26% 40.19% -0.07%
==========================================
Files 683 683
Lines 74480 74483 +3
==========================================
- Hits 29989 29939 -50
- Misses 39263 39304 +41
- Partials 5228 5240 +12
|
Co-authored-by: Aayush Rajasekaran <arajasek94@gmail.com>
magik6k
reviewed
Apr 25, 2022
Using OR, instead of having a separate if/else
magik6k
reviewed
Apr 25, 2022
fix: ux: update `lotus-wallet run` description
Currently the lotus-worker does not check or download the params if SnapDeal tasks are enabled, meaning that you get an param-error if you for example a run a new 'PC1 / RU / PRU2' worker and a SnapDeal gets assigned to it. Reported in #8549.
Using OR, instead of having a separate if/else
Rebasing on master
…n90/lotus into fix/worker-params-snap-deals
|
I will have to read up a bit on git rebasing - had some issues getting it correctly here. Created a new PR for it #8555 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the lotus-worker does not check or download the params if Prove Replica Update tasks are enabled, meaning that you get an param-error if you for example a run a new 'PC1 / RU / PRU2' worker and a SnapDeal gets assigned to it. Reported in #8549.
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, testarea: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps