Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: vm: add actor error backtraces to FVM #8524

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Apr 20, 2022

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@Stebalien Stebalien requested a review from a team as a code owner April 20, 2022 15:15
@vyzo vyzo marked this pull request as draft April 20, 2022 15:19
@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #8524 (8fd6217) into master (f9a4a40) will increase coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head 8fd6217 differs from pull request most recent head 6c0c111. Consider uploading reports for the commit 6c0c111 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8524      +/-   ##
==========================================
+ Coverage   40.82%   40.86%   +0.03%     
==========================================
  Files         686      686              
  Lines       75697    75595     -102     
==========================================
- Hits        30904    30890      -14     
+ Misses      39455    39386      -69     
+ Partials     5338     5319      -19     
Impacted Files Coverage Δ
chain/vm/fvm.go 0.00% <0.00%> (ø)
node/modules/storageminer_idxprov.go 76.08% <0.00%> (-6.27%) ⬇️
chain/exchange/peer_tracker.go 66.66% <0.00%> (-4.31%) ⬇️
chain/events/events_height.go 68.90% <0.00%> (-2.53%) ⬇️
storage/wdpost_sched.go 85.29% <0.00%> (-1.97%) ⬇️
extern/sector-storage/ffiwrapper/sealer_cgo.go 58.78% <0.00%> (-1.67%) ⬇️
storage/wdpost_changehandler.go 98.58% <0.00%> (-0.95%) ⬇️
blockstore/autobatch.go 57.14% <0.00%> (-0.85%) ⬇️
extern/sector-storage/sched.go 85.93% <0.00%> (-0.77%) ⬇️
extern/sector-storage/worker_tracked.go 79.82% <0.00%> (-0.69%) ⬇️
... and 27 more

@Stebalien Stebalien force-pushed the steb/error-backtrace branch from 8fd6217 to b985db4 Compare April 22, 2022 16:29
@Stebalien Stebalien marked this pull request as ready for review April 22, 2022 16:29
@Stebalien Stebalien force-pushed the steb/error-backtrace branch from b985db4 to d8cc785 Compare April 22, 2022 16:30
@Stebalien Stebalien changed the title feat: add actor error backtraces feat: vm: add actor error backtraces Apr 22, 2022
@Stebalien Stebalien changed the title feat: vm: add actor error backtraces feat: vm: add actor error backtraces to FVM Apr 22, 2022
@Stebalien Stebalien force-pushed the steb/error-backtrace branch from d8cc785 to fa7ff2d Compare April 22, 2022 16:30
@Stebalien Stebalien requested review from arajasek and magik6k April 22, 2022 16:34
@Stebalien Stebalien force-pushed the steb/error-backtrace branch from fa7ff2d to 6c0c111 Compare April 28, 2022 17:58
@vyzo
Copy link
Contributor

vyzo commented Apr 28, 2022

we need this for nv16 branch as well, mind merging there as well?

@Stebalien Stebalien enabled auto-merge April 28, 2022 21:09
@Stebalien Stebalien disabled auto-merge April 29, 2022 13:05
@Stebalien Stebalien enabled auto-merge April 29, 2022 13:05
@Stebalien Stebalien merged commit 88f8c7d into master Apr 29, 2022
@Stebalien Stebalien deleted the steb/error-backtrace branch April 29, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants