Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail to add expired precommits to a batch #8479

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Conversation

arajasek
Copy link
Contributor

Related Issues

#6572

Proposed Changes

The current practice of returning "now" as the cutoff for expired precommits doesn't make sense -- we should just say "it's too late" and fail.

This should send us through the "fail" pipeline into this check, at which point we'll redo PC.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@arajasek arajasek requested a review from a team as a code owner April 13, 2022 03:47
@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #8479 (42a79d5) into master (02a6176) will decrease coverage by 0.01%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8479      +/-   ##
==========================================
- Coverage   40.78%   40.76%   -0.02%     
==========================================
  Files         686      686              
  Lines       75498    75501       +3     
==========================================
- Hits        30789    30778      -11     
- Misses      39406    39413       +7     
- Partials     5303     5310       +7     
Impacted Files Coverage Δ
extern/storage-sealing/precommit_batch.go 65.90% <57.14%> (-0.38%) ⬇️
storage/wdpost_sched.go 75.49% <0.00%> (-5.89%) ⬇️
chain/exchange/peer_tracker.go 66.66% <0.00%> (-4.31%) ⬇️
chain/stmgr/searchwait.go 67.30% <0.00%> (-2.57%) ⬇️
chain/events/events_height.go 68.90% <0.00%> (-2.53%) ⬇️
chain/events/observer.go 80.00% <0.00%> (-1.38%) ⬇️
miner/miner.go 56.06% <0.00%> (-1.32%) ⬇️
chain/gen/gen.go 68.19% <0.00%> (-1.23%) ⬇️
extern/sector-storage/sched_worker.go 79.41% <0.00%> (-1.18%) ⬇️
itests/kit/blockminer.go 69.56% <0.00%> (-1.09%) ⬇️
... and 13 more

@magik6k magik6k merged commit 88142d2 into master Apr 13, 2022
@magik6k magik6k deleted the asr/expired-cutoff branch April 13, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants