Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: config: default-disable kvlog #8477

Merged
merged 1 commit into from
Apr 12, 2022
Merged

chore: config: default-disable kvlog #8477

merged 1 commit into from
Apr 12, 2022

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Apr 12, 2022

KVLog in its current form isn't generated correctly, and so far we didn't see any metadata corruption which couldn't be repaired with normal leveldb repair tools;

At some point it may be worth implementing a v2 of kvlog, but for now I think it's better to disable it by default as it seems to be a constant source of problems.

@magik6k magik6k requested a review from a team as a code owner April 12, 2022 21:21
@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #8477 (cc70557) into master (aca9496) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8477      +/-   ##
==========================================
- Coverage   40.77%   40.72%   -0.05%     
==========================================
  Files         686      686              
  Lines       75495    75498       +3     
==========================================
- Hits        30782    30746      -36     
- Misses      39404    39432      +28     
- Partials     5309     5320      +11     
Impacted Files Coverage Δ
node/config/def.go 97.75% <100.00%> (+0.03%) ⬆️
chain/events/state/fastapi.go 75.00% <0.00%> (-25.00%) ⬇️
chain/events/message_cache.go 87.50% <0.00%> (-12.50%) ⬇️
node/modules/storage.go 76.92% <0.00%> (-7.70%) ⬇️
storage/wdpost_sched.go 75.49% <0.00%> (-5.89%) ⬇️
chain/events/events_called.go 83.90% <0.00%> (-4.40%) ⬇️
extern/storage-sealing/currentdealinfo.go 71.17% <0.00%> (-3.61%) ⬇️
chain/stmgr/searchwait.go 67.30% <0.00%> (-2.57%) ⬇️
chain/sub/incoming.go 59.02% <0.00%> (-2.45%) ⬇️
storage/wdpost_run.go 70.48% <0.00%> (-0.98%) ⬇️
... and 14 more

@jennijuju jennijuju merged commit 02a6176 into master Apr 12, 2022
@jennijuju jennijuju deleted the fix/disable-kvlog branch April 12, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants