Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:sealing:check index out of bounds against correct param length not return length #8475

Merged
merged 6 commits into from
Apr 18, 2022

Conversation

ZenGround0
Copy link
Contributor

@ZenGround0 ZenGround0 commented Apr 12, 2022

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@ZenGround0 ZenGround0 requested a review from a team as a code owner April 12, 2022 18:47
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs make gen; The failing test may have a good reason to be failing

=== RUN   TestGetCurrentDealInfo/deal_lookup_succeeds_when_theres_a_separate_deal_failure
nv: 14
unserialized deal ids: [8 10]
    currentdealinfo_test.go:295: 
        	Error Trace:	currentdealinfo_test.go:295
        	Error:      	Not equal: 
        	            	expected: 0xa
        	            	actual  : 0x0
        	Test:       	TestGetCurrentDealInfo/deal_lookup_succeeds_when_theres_a_separate_deal_failure
    --- FAIL: TestGetCurrentDealInfo/deal_lookup_succeeds_when_theres_a_separate_deal_failure (0.00s)

chain/actors/builtin/market/v7.go Outdated Show resolved Hide resolved
@ZenGround0
Copy link
Contributor Author

Test failure is because tests use this to sort deals which doesn't work which ruins order invariants which causes flake.

@ZenGround0 ZenGround0 requested a review from magik6k April 14, 2022 02:23
@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #8475 (5bdcc7d) into master (aca9496) will decrease coverage by 0.05%.
The diff coverage is 53.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8475      +/-   ##
==========================================
- Coverage   40.77%   40.72%   -0.06%     
==========================================
  Files         686      686              
  Lines       75495    75524      +29     
==========================================
- Hits        30782    30755      -27     
- Misses      39404    39441      +37     
- Partials     5309     5328      +19     
Impacted Files Coverage Δ
chain/actors/builtin/market/market.go 66.98% <ø> (ø)
chain/actors/builtin/market/v5.go 16.12% <0.00%> (ø)
chain/actors/builtin/market/v7.go 45.98% <46.66%> (+0.82%) ⬆️
markets/storageadapter/client.go 40.55% <50.00%> (ø)
chain/actors/builtin/market/v6.go 23.35% <60.00%> (+4.80%) ⬆️
extern/storage-sealing/currentdealinfo.go 70.17% <71.42%> (-4.60%) ⬇️
chain/events/state/fastapi.go 75.00% <0.00%> (-25.00%) ⬇️
chain/actors/builtin/miner/diff.go 52.94% <0.00%> (-5.89%) ⬇️
chain/types/tipset_key.go 85.96% <0.00%> (-3.51%) ⬇️
... and 21 more

@magik6k magik6k merged commit eb894b0 into master Apr 18, 2022
@magik6k magik6k deleted the fix/deal-idx-oob branch April 18, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants