-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:sealing:check index out of bounds against correct param length not return length #8475
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs make gen
; The failing test may have a good reason to be failing
=== RUN TestGetCurrentDealInfo/deal_lookup_succeeds_when_theres_a_separate_deal_failure
nv: 14
unserialized deal ids: [8 10]
currentdealinfo_test.go:295:
Error Trace: currentdealinfo_test.go:295
Error: Not equal:
expected: 0xa
actual : 0x0
Test: TestGetCurrentDealInfo/deal_lookup_succeeds_when_theres_a_separate_deal_failure
--- FAIL: TestGetCurrentDealInfo/deal_lookup_succeeds_when_theres_a_separate_deal_failure (0.00s)
Test failure is because tests use this to sort deals which doesn't work which ruins order invariants which causes flake. |
Codecov Report
@@ Coverage Diff @@
## master #8475 +/- ##
==========================================
- Coverage 40.77% 40.72% -0.06%
==========================================
Files 686 686
Lines 75495 75524 +29
==========================================
- Hits 30782 30755 -27
- Misses 39404 39441 +37
- Partials 5309 5328 +19
|
Related Issues
Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, testarea
: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps