Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ux: wallet: update delete usage #8442

Merged
merged 3 commits into from
Apr 13, 2022
Merged

ux: wallet: update delete usage #8442

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
255ff1a
ux: wallet: soft-delete wallet
rjan90 Apr 6, 2022
96ee416
Fix TestWalletDelete-test
rjan90 Apr 7, 2022
c3f2f12
Revert soft-delete cmd
rjan90 Apr 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cli/wallet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,8 +499,8 @@ var walletVerify = &cli.Command{
}

var walletDelete = &cli.Command{
Name: "delete",
Usage: "Delete an account from the wallet",
Name: "soft-delete",
Usage: "Soft delete an address from the wallet - hard deletion needed for permanent removal",
ArgsUsage: "<address> ",
Action: func(cctx *cli.Context) error {
api, closer, err := GetFullNodeAPI(cctx)
Expand Down
2 changes: 1 addition & 1 deletion cli/wallet_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ func TestWalletDelete(t *testing.T) {
mockApi.EXPECT().WalletDelete(ctx, addr).Return(nil)

//stm: @CLI_WALLET_DELETE_001
err = app.Run([]string{"wallet", "delete", "f01234"})
err = app.Run([]string{"wallet", "soft-delete", "f01234"})
assert.NoError(t, err)
}

Expand Down
8 changes: 4 additions & 4 deletions documentation/en/cli-lotus.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ COMMANDS:
set-default Set default wallet address
sign sign a message
verify verify the signature of a message
delete Delete an account from the wallet
soft-delete Soft delete an address from the wallet - hard deletion needed for permanent removal
market Interact with market balances
help, h Shows a list of commands or help for one command

Expand Down Expand Up @@ -343,13 +343,13 @@ OPTIONS:

```

### lotus wallet delete
### lotus wallet soft-delete
```
NAME:
lotus wallet delete - Delete an account from the wallet
lotus wallet soft-delete - Soft delete an address from the wallet - hard deletion needed for permanent removal

USAGE:
lotus wallet delete [command options] <address>
lotus wallet soft-delete [command options] <address>

OPTIONS:
--help, -h show help (default: false)
Expand Down