Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert appimage removal #8439

Merged
merged 2 commits into from
Apr 11, 2022
Merged

Revert appimage removal #8439

merged 2 commits into from
Apr 11, 2022

Conversation

coryschwartz
Copy link

this reverts two commits that were used to remove the appimage from release bundles.

6b08680
7d65a26

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@coryschwartz coryschwartz requested a review from a team as a code owner April 6, 2022 00:27
@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #8439 (c715254) into master (0fa74a7) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8439      +/-   ##
==========================================
- Coverage   40.66%   40.61%   -0.05%     
==========================================
  Files         686      686              
  Lines       75398    75398              
==========================================
- Hits        30661    30624      -37     
- Misses      39443    39467      +24     
- Partials     5294     5307      +13     
Impacted Files Coverage Δ
chain/events/message_cache.go 87.50% <0.00%> (-12.50%) ⬇️
chain/events/observer.go 71.64% <0.00%> (-8.21%) ⬇️
storage/wdpost_sched.go 81.37% <0.00%> (-5.89%) ⬇️
miner/miner.go 56.06% <0.00%> (-3.94%) ⬇️
chain/events/events_called.go 85.36% <0.00%> (-1.96%) ⬇️
chain/store/store.go 64.33% <0.00%> (-1.50%) ⬇️
storage/wdpost_changehandler.go 98.11% <0.00%> (-1.42%) ⬇️
chain/gen/gen.go 68.19% <0.00%> (-1.23%) ⬇️
extern/sector-storage/sched_worker.go 78.82% <0.00%> (-1.18%) ⬇️
extern/sector-storage/sched.go 84.77% <0.00%> (-0.83%) ⬇️
... and 12 more

Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@magik6k magik6k merged commit 3cd5636 into master Apr 11, 2022
@magik6k magik6k deleted the revert-appimage-removal branch April 11, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants