Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bench: simple sealing operations commands #8373

Merged
merged 6 commits into from
May 30, 2022
Merged

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Mar 26, 2022

Related Issues

This is (eventually going to be) adding new lotus bench commands, mostly aimed to make new PoSt methods in #7971 benchmarkable.

Proposed Changes

This PR adds a bunch of new commands to lotus-bench which make it possible to execute individual sealing operations on sector files manually

Todo:

  • PoSt challenge generation
  • Distributed PoSt ops
  • Commit 1/2
  • SnapDeals
  • Output timing info
  • Good usage in the lotus-bench simple command
  • Flags to make it possible to reproduce any sector (miner, sector num, ticket, etc.) - can be done later
  • Full run script

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@magik6k magik6k mentioned this pull request Mar 26, 2022
5 tasks
Base automatically changed from feat/post-worker to master March 26, 2022 00:31
@codecov
Copy link

codecov bot commented Mar 26, 2022

Codecov Report

Merging #8373 (c2c6d6c) into master (6f2c8d6) will decrease coverage by 0.32%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8373      +/-   ##
==========================================
- Coverage   40.89%   40.56%   -0.33%     
==========================================
  Files         688      689       +1     
  Lines       76047    76501     +454     
==========================================
- Hits        31098    31035      -63     
- Misses      39613    40115     +502     
- Partials     5336     5351      +15     
Impacted Files Coverage Δ
cmd/lotus-bench/main.go 0.00% <0.00%> (ø)
cmd/lotus-bench/simple.go 0.00% <0.00%> (ø)
chain/events/state/fastapi.go 75.00% <0.00%> (-25.00%) ⬇️
chain/events/message_cache.go 87.50% <0.00%> (-12.50%) ⬇️
chain/actors/builtin/miner/diff.go 48.52% <0.00%> (-10.30%) ⬇️
storage/wdpost_sched.go 79.41% <0.00%> (-5.89%) ⬇️
chain/exchange/peer_tracker.go 66.66% <0.00%> (-4.31%) ⬇️
extern/storage-sealing/currentdealinfo.go 71.92% <0.00%> (-3.51%) ⬇️
chain/stmgr/searchwait.go 67.30% <0.00%> (-2.57%) ⬇️
chain/events/events_height.go 68.90% <0.00%> (-2.53%) ⬇️
... and 14 more

@magik6k magik6k force-pushed the feat/simple-op-bench branch 4 times, most recently from f5f9c28 to 4ff3835 Compare April 1, 2022 01:49
@magik6k magik6k force-pushed the feat/simple-op-bench branch from 4ff3835 to 9a64758 Compare April 2, 2022 21:11
@magik6k magik6k force-pushed the feat/simple-op-bench branch from 0265f05 to 86d326f Compare May 26, 2022 08:53
@magik6k magik6k marked this pull request as ready for review May 26, 2022 10:08
@magik6k magik6k requested a review from a team as a code owner May 26, 2022 10:08
@magik6k magik6k force-pushed the feat/simple-op-bench branch from f40f9d1 to c2c6d6c Compare May 26, 2022 10:09
@magik6k magik6k force-pushed the feat/simple-op-bench branch from c2c6d6c to e148663 Compare May 30, 2022 13:44
@magik6k magik6k requested a review from geoff-vball May 30, 2022 14:20
@magik6k magik6k merged commit 285c9b9 into master May 30, 2022
@magik6k magik6k deleted the feat/simple-op-bench branch May 30, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants