Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:snapup: Rename error message #8370

Merged
merged 1 commit into from
Mar 25, 2022
Merged

fix:snapup: Rename error message #8370

merged 1 commit into from
Mar 25, 2022

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Mar 25, 2022

Proposed Changes

Renaming the the error-message you get if you try to snap-up the same sector twice, to better reflect that you are snapping a sector, and not mark-for-upgrade, which now has been deprecated.

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

Renaming the the error-message you get if you try to snap-up the same sector twice, to better reflect that you are snapping a sector, and not marki-for-upgrade, which now has been deprecated.
@rjan90 rjan90 requested a review from a team as a code owner March 25, 2022 15:41
@magik6k magik6k merged commit 4e2d7fe into filecoin-project:master Mar 25, 2022
@rjan90 rjan90 deleted the ux/sectors-snap-up branch March 28, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants