Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multisig: Print "waiting for confirmation.." #8368

Merged
merged 1 commit into from
Mar 25, 2022
Merged

fix: multisig: Print "waiting for confirmation.." #8368

merged 1 commit into from
Mar 25, 2022

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Mar 24, 2022

Prints an additional "waiting for confirmation.." when running lotus msig create [address1 address2] to indicate that the command is waiting for the msg to be mined into a block, and not just hanging.

Related Issues

Should fix #4053

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

Prints an addition "waiting for confirmation.." when running `lotus msig create [address1 address2]` to indicate that command is waiting for the msg to be mined into block, and not just hanging.

Should fix #4053
@rjan90 rjan90 requested a review from a team as a code owner March 24, 2022 15:16
@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #8368 (da64f24) into master (caeeb6a) will increase coverage by 5.48%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8368      +/-   ##
==========================================
+ Coverage   34.75%   40.23%   +5.48%     
==========================================
  Files         678      683       +5     
  Lines       74252    74481     +229     
==========================================
+ Hits        25804    29966    +4162     
+ Misses      43636    39283    -4353     
- Partials     4812     5232     +420     
Impacted Files Coverage Δ
cli/multisig.go 12.71% <100.00%> (+0.09%) ⬆️
extern/storage-sealing/currentdealinfo.go 72.97% <0.00%> (-3.61%) ⬇️
miner/miner.go 57.37% <0.00%> (-1.64%) ⬇️
extern/storage-sealing/fsm.go 60.73% <0.00%> (-0.68%) ⬇️
itests/kit/blockminer.go 69.02% <0.00%> (-0.55%) ⬇️
node/impl/storminer.go 22.59% <0.00%> (-0.32%) ⬇️
chain/actors/builtin/paych/mock/mock.go 71.42% <0.00%> (ø)
journal/mockjournal/journal.go 71.42% <0.00%> (ø)
lib/nullreader/reader.go 0.00% <0.00%> (ø)
chain/vectors/gen/main.go 2.36% <0.00%> (ø)
... and 138 more

@jennijuju jennijuju merged commit a449937 into filecoin-project:master Mar 25, 2022
@rjan90 rjan90 deleted the fix/ux-msig-create branch March 28, 2022 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

msig create should show intermediate progress
2 participants