Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sealing: FinalizeSector doesn't need sealed replica access #8337

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Mar 17, 2022

Related Issues

Probably fixes some of the "stuck in finalize" issues

Proposed Changes

FinalizeSector doesn't touch the sealed sector file, so requiring it to exist on the worker next to the cache can only cause issues - for example when a sector was in the middle of being finalized, the sealed file might have been moved off the worker just before it restarted - causing Finalize to restart, and get stuck on the early stage which expects sealed/cache files to still be on the worker - where we only really need the cache

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • [hopefully] CI is green

@magik6k magik6k requested a review from a team as a code owner March 17, 2022 14:24
Copy link
Contributor

@ZenGround0 ZenGround0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checking: this doesn't apply in FinalizeReplicaUpdate because we do a MoveStorage call on the sealed replica and the worker needs access to the sector to do the move?

@magik6k
Copy link
Contributor Author

magik6k commented Mar 17, 2022

Correct

@magik6k magik6k merged commit b366e2c into master Mar 17, 2022
@magik6k magik6k deleted the fix/fin-sealed-acc branch March 17, 2022 15:58
magik6k added a commit that referenced this pull request Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants