feat: conformance & tvx: support ReportConsensusFault messages #8302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ants. And also use inclusion tipset to run the message, which is more correct than the execution tipset.
raulk
added a commit
to filecoin-project/fvm-test-vectors
that referenced
this pull request
Mar 11, 2022
Fix was required in tvx: filecoin-project/lotus#8302
raulk
commented
Mar 12, 2022
| @@ -151,7 +152,7 @@ func doExtractMessage(opts extractOpts) error { | |||
| preroot = root | |||
| applyret, postroot, err = driver.ExecuteMessage(pst.Blockstore, conformance.ExecuteMessageParams{ | |||
| Preroot: preroot, | |||
| Epoch: execTs.Height(), | |||
There was a problem hiding this comment.
The execution epoch was wrong, it should be the inclusion tipset.
Comment on lines
+420
to
+425
| case mode == PrecursorSelectParticipants && | ||
| msgSenderID == senderID || | ||
| msgRecipientID == recipientID || | ||
| msgSenderID == recipientID || | ||
| msgRecipientID == senderID: | ||
| related = append(related, m.Message) |
There was a problem hiding this comment.
We now find precursors by matching on all participants involved.
arajasek
approved these changes
Jun 7, 2022
aakoshh
reviewed
Nov 15, 2022
Comment on lines
+420
to
+424
| case mode == PrecursorSelectParticipants && | ||
| msgSenderID == senderID || | ||
| msgRecipientID == recipientID || | ||
| msgSenderID == recipientID || | ||
| msgRecipientID == senderID: |
There was a problem hiding this comment.
A parentheses seems to be missing around the OR parts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
filecoin-project/ref-fvm#381
Proposed Changes
Introduces the ability to extract test vectors that directly or indirectly rely on the
VerifyConsensusFaultsyscall. That syscall ends up performing a chain lookback to load the state tree at the last final epoch, from which the worker key is loaded.The solution here assumes that the worker key hasn't changed in the non-finalized portion of the chain, and returns the precondition state tree to perform the worker key lookup. See filecoin-project/ref-fvm#381 (comment) for more details (thanks @arajasek for the suggestion!).
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, testarea: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps