test: use T.TempDir to create temporary test directory
#8295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8295 +/- ##
==========================================
- Coverage 40.34% 40.31% -0.03%
==========================================
Files 679 679
Lines 73985 73958 -27
==========================================
- Hits 29846 29819 -27
- Misses 38900 38924 +24
+ Partials 5239 5215 -24
|
ZenGround0
requested changes
Mar 14, 2022
There was a problem hiding this comment.
Other than the test storage in the sector storage manager this LGTM. It looks like you've been keeping the ioutil temp dirs around in places where the current test does not delete the dir 👍. However I am less familiar with these other tests so it's hard to be sure.
Please go through and double check there are no more places where this change will remove test directories the current tests wouldn't and then this will be good to go.
The directory created by `T.TempDir` is automatically removed when the test and all its subtests complete. Reference: https://pkg.go.dev/testing#T.TempDir Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
ZenGround0
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
A testing enhancement.
Proposed Changes
Replaces
ioutil.TempDirwithT.TempDirfunction from thetestingpackage to create temporary directory. The directory created byT.TempDiris automatically removed when the test and all its subtests complete.Additional Info
Reference: https://pkg.go.dev/testing#T.TempDir
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, testarea: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps