Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore:sealing:remove endpoint from cli #8215

Merged
merged 2 commits into from
Mar 16, 2022
Merged

Conversation

ZenGround0
Copy link
Contributor

@ZenGround0 ZenGround0 commented Mar 1, 2022

Related Issues

#7934

Proposed Changes

Remove mark-for-upgrade cli command and underlying sealer methods

Additional Info

I'm not yet removing the upgrade field from the FSM's sector info because afaik this would cause failure to reload old sector infos. @magik6k what's the best way to do this? Have we migrated fsm sector info data before?

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@ZenGround0 ZenGround0 requested a review from a team as a code owner March 1, 2022 18:31
@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #8215 (59ef2fe) into master (6291c0c) will decrease coverage by 0.04%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8215      +/-   ##
==========================================
- Coverage   40.24%   40.20%   -0.05%     
==========================================
  Files         666      666              
  Lines       72769    72675      -94     
==========================================
- Hits        29284    29216      -68     
+ Misses      38359    38324      -35     
- Partials     5126     5135       +9     
Impacted Files Coverage Δ
api/api_storage.go 0.00% <ø> (ø)
cmd/lotus-miner/sectors.go 14.35% <ø> (+0.36%) ⬆️
extern/storage-sealing/sealing.go 78.65% <ø> (-0.24%) ⬇️
extern/storage-sealing/upgrade_queue.go 45.23% <ø> (+11.21%) ⬆️
storage/miner_sealing.go 85.39% <50.00%> (-0.33%) ⬇️
extern/storage-sealing/states_sealing.go 38.27% <100.00%> (+0.23%) ⬆️
markets/loggers/loggers.go 88.88% <0.00%> (-11.12%) ⬇️
chain/actors/builtin/miner/diff.go 48.52% <0.00%> (-10.30%) ⬇️
cli/util.go 70.83% <0.00%> (-8.34%) ⬇️
chain/stmgr/call.go 67.87% <0.00%> (-7.28%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6291c0c...59ef2fe. Read the comment docs.

@ZenGround0
Copy link
Contributor Author

Today from @magik6k cbor-gen map deserializer will actually just ignore map fields that don't exist in the schema if it finds them on disk. So we should be ok to remove the upgrade field from the sector info. We'll want to test out new code on old sector infos before merging, probably in a devnet.

@magik6k magik6k merged commit 9f6f94b into master Mar 16, 2022
@magik6k magik6k deleted the feat/remove-mark-for-upgrade branch March 16, 2022 14:33
@magik6k
Copy link
Contributor

magik6k commented Mar 16, 2022

(tested on my setup, seems to work)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants