fix: cli: Reset miner/ask lists in interactive deal 'miner' step #8155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug fixed : if hitting return instead of filling with a valid value, the CLI crashed (line 796) Change return err by continue to ask a valid value again
Bug fixed : if hitting return instead of filling with a valid value, the CLI crashed (line 796) Change return err by continue to ask a valid value again
Commit to fix lint reported errors during tests on CircleCI (remove blank lines x2)
Commit to fix lint reported errors during tests on CircleCI (remove trailling whitespace)
Clear the list of miner addresses and successfull get-asked before asking for new ones Previous behavior : if get-ask failed for miner(s), the faulty miner will be retried each time, so you have to stop the command and start again to change this faulty miner (instead of removing from the list on the new attempt)
…king for new ones Previous behavior : if get-ask failed for miner(s), the faulty miner will be retried each time, so you have to stop the command and start again to change this faulty miner (instead of removing from the list on the new attempt)
Codecov Report
@@ Coverage Diff @@
## master #8155 +/- ##
==========================================
- Coverage 39.39% 39.35% -0.04%
==========================================
Files 666 666
Lines 72466 72469 +3
==========================================
- Hits 28546 28522 -24
- Misses 38995 39014 +19
- Partials 4925 4933 +8
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes #8095
Proposed Changes
Clear the list of miners addresses set on the first attempt, because without clearing the list, on the next attempt, faulty miner is always in the list, so error is throw again.
Also, clear the list of all successfull get-ask before asking new addresses, because :