Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sealing: replica-update variable name is inconsistent #8123

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

jennijuju
Copy link
Member

@jennijuju jennijuju commented Feb 17, 2022

Related Issues

running lotus-worker run should have RU enabled by default, however, its not cuz the vairable cant be found 😄

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@jennijuju jennijuju requested a review from a team as a code owner February 17, 2022 00:35
@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #8123 (43c0344) into release/v1.14.0 (7fd4c96) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v1.14.0    #8123      +/-   ##
===================================================
+ Coverage            39.32%   39.33%   +0.01%     
===================================================
  Files                  657      657              
  Lines                71041    71041              
===================================================
+ Hits                 27936    27944       +8     
+ Misses               38257    38251       -6     
+ Partials              4848     4846       -2     
Impacted Files Coverage Δ
cmd/lotus-seal-worker/main.go 0.00% <0.00%> (ø)
chain/actors/builtin/miner/diff.go 48.52% <0.00%> (-10.30%) ⬇️
miner/warmup.go 70.83% <0.00%> (-4.17%) ⬇️
storage/miner.go 69.31% <0.00%> (-2.28%) ⬇️
miner/miner.go 55.40% <0.00%> (-1.97%) ⬇️
blockstore/autobatch.go 58.82% <0.00%> (-1.69%) ⬇️
chain/messagepool/selection.go 83.52% <0.00%> (-0.78%) ⬇️
chain/actors/builtin/miner/v7.go 53.21% <0.00%> (+0.30%) ⬆️
extern/sector-storage/sched_worker.go 79.06% <0.00%> (+0.58%) ⬆️
extern/sector-storage/stores/local.go 60.00% <0.00%> (+0.83%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fd4c96...43c0344. Read the comment docs.

@magik6k
Copy link
Contributor

magik6k commented Feb 17, 2022

Also port to other branches?

@arajasek arajasek added this to the v1.14.0 milestone Feb 17, 2022
@arajasek arajasek merged commit 33134e6 into release/v1.14.0 Feb 17, 2022
@arajasek arajasek deleted the jen/fixcli branch February 17, 2022 19:06
This was referenced Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants