-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: convert RepoType from int to interface #8086
Conversation
78279c2
to
4df3c89
Compare
Codecov Report
@@ Coverage Diff @@
## master #8086 +/- ##
==========================================
+ Coverage 40.23% 40.53% +0.29%
==========================================
Files 682 676 -6
Lines 74428 73575 -853
==========================================
- Hits 29946 29821 -125
+ Misses 39247 38537 -710
+ Partials 5235 5217 -18
|
b2096e3
to
9fd7e71
Compare
Thanks for review @magik6k !!! I think I addressed all your comments. |
@magik6k we modified a bit further the config in order to be able to pass in |
…ost (#8172) * refactor sealingCfg and dealmakingCfg to be able to abstract Config * fix error messages
f252608
to
acbfc87
Compare
@magik6k I think I addressed the latest comments. |
057c09b
to
0d6493e
Compare
@magik6k I rebased to master, and I think this is ready for merge. Could you have another look, and let me know if you think we need anything else as part of this PR? |
thanks!! :) |
Related Issues
This PR is convering
RepoType
type fromint
tointerface
, so that we can use therepo
package in other projects and provide a custom Config, that is not referred to in Lotus (such asconfig.Boost
).The new usage can be seen at: filecoin-project/boost#231
We want to be using the
filecoin-project/lotus/node/repo
package, due to the fx dependency injection, as we want to integrate all Lotus markets dependencies directly in boost before releasing the alpha version.Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, testarea
: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps