bug: sealing: FinalizeReplicaUpdate

[magik6k]

Related Issues

Closes #8012

Depends on filecoin-project/specs-storage#22

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

• All commits have a clear commit message.
• The PR title is in the form of of <PR type>: <area>: <change being made>
  • example: fix: mempool: Introduce a cache for valid signatures
  • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
  • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
• This PR has tests for new functionality or change in behaviour
• If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
• CI is green

[magik6k]

Main todo; not sure if passing UpdateCache into ClearCache is/does the correct thing

[codecov]

Codecov Report

Merging #8018 (84d70ca) into master (b27196b) will decrease coverage by 0.01%.
The diff coverage is 52.22%.

@@            Coverage Diff             @@
##           master    #8018      +/-   ##
==========================================
- Coverage   39.21%   39.19%   -0.02%     
==========================================
  Files         660      660              
  Lines       71436    71587     +151     
==========================================
+ Hits        28014    28062      +48     
- Misses      38602    38693      +91     
- Partials     4820     4832      +12     

Impacted Files	Coverage Δ
api/api_storage.go	0.00% <ø> (ø)
cmd/lotus-miner/info.go	60.11% <ø> (ø)
cmd/lotus-seal-worker/main.go	0.00% <0.00%> (ø)
extern/sector-storage/mock/mock.go	60.62% <0.00%> (-0.64%)	⬇️
extern/sector-storage/sealtasks/task.go	81.81% <ø> (ø)
extern/sector-storage/storiface/worker.go	76.00% <ø> (ø)
extern/storage-sealing/states_failed.go	0.00% <0.00%> (ø)
extern/sector-storage/worker_local.go	60.00% <36.36%> (-0.80%)	⬇️
extern/storage-sealing/fsm_events.go	50.00% <40.00%> (-0.33%)	⬇️
extern/sector-storage/ffiwrapper/sealer_cgo.go	58.62% <40.74%> (-0.95%)	⬇️
... and 29 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b27196b...84d70ca. Read the comment docs.

[ZenGround0]

LGTM

One thing this reminds me of is that we should probably track work for calling manager ReleaseSectorKey during the finalize step based on a config param. I think right now we end up carrying original Replica, UpdatedReplica and UnsealedData by default. And I don't think there's a good way to configure dropping the sector key.

--edit--
reminder to update specs-storage dependency to master

[remakeZK]

Should old sealed files keep in the path until ChainFanilty?Since winning post check the sector state in the past, clear old sealed immediately may cause some unexcept problem

[magik6k]

Should old sealed files keep in the path until ChainFanilty?Since winning post check the sector state in the past, clear old sealed immediately may cause some unexcept problem

They are kept, this PR doesn't handle cleanup of those, this will come as a follow-up

[magik6k]

Or maybe that's easy enough to do now

[ZenGround0]

Yeah thanks @remakeZK, I was forgetting about winning post. We'll need a separate state to do sector key cleanup, or postpone finalize by 2 finalities and do it there.

[jennijuju]

Need better PR title