tvx: supply network version when extracting messages. #7996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
approved these changes
Jan 24, 2022
| @@ -43,6 +42,15 @@ func doExtractMessage(opts extractOpts) error { | |||
| return fmt.Errorf("failed to resolve message and tipsets from chain: %w", err) | |||
| } | |||
|
|
|||
| // Assumes that the desired message isn't at the boundary of network versions. | |||
| // Otherwise this will be inaccurate. But it's such a tiny edge case that | |||
There was a problem hiding this comment.
These are actually a pretty key edge case that we need to be testing, esp what happens around null tipsets...but that's for later...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
tvxtool to pass in the relevant network version when extracting test vectors.