correctness fixes for the autobatch blockstore #7940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
approved these changes
Jan 12, 2022
| } | ||
|
|
||
| bs.doFlushLock.Lock() |
There was a problem hiding this comment.
Is this just to make sure that any earlier claimers of the lock finish before we return?
There was a problem hiding this comment.
Concurrent Flush and Shutdown.
1. Simplify shutdown and make it idempotent by using a context. 2. Make sure `Flush` actually _fully_ flushes if the previous flush failed. 3. Don't clear the flush batch if flushing fails.
c7246e1 to
2a862d4
Compare
|
(forgot to create the channel) |
Codecov Report
@@ Coverage Diff @@
## master #7940 +/- ##
==========================================
+ Coverage 39.32% 39.34% +0.01%
==========================================
Files 658 658
Lines 71119 71122 +3
==========================================
+ Hits 27970 27981 +11
+ Misses 38332 38331 -1
+ Partials 4817 4810 -7
Continue to review full report at Codecov.
|
|
folllowing the PR template - a nice PR title should be created so our change log is pretty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flushactually fully flushes if the previous flush failed.