-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: #7891 sectors: disable existing existing cc upgrade path 2 days before the upgrade epoch #7900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- FSM handles the actual cc upgrade process including error states - PoSting (winning and window) works over upgraded and upgrading sectors - Integration test and changes to itest framework to reduce flakes - Update CLI to handle new upgrade - Update dependencies
…de to avoid unexpected edge cases that may cause deal/sector failure
jennijuju
changed the title
Disable mark-for-upgrade two days before the network v15 OhSnap Upgrade
enhancement: #7891 sectors: disable existing existing cc upgrade path 2 days before the upgrade epoch
Jan 7, 2022
ZenGround0
force-pushed
the
feat/snap-deals
branch
from
January 10, 2022 10:10
415360c
to
825e2c9
Compare
arajasek
approved these changes
Jan 11, 2022
cmd/lotus-miner/sectors.go
Outdated
@@ -1546,6 +1549,18 @@ var sectorsMarkForUpgradeCmd = &cli.Command{ | |||
if nv >= network.Version15 { | |||
return xerrors.Errorf("classic cc upgrades disabled v15 and beyond, use `snap-up`") | |||
} | |||
|
|||
// disable mark for upgrade two days before the ntwk v15 upgrade | |||
// TODO: remove the following block in v1.15.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the entire mechanism will be removed in 1.15.1
arajasek
force-pushed
the
feat/snap-deals
branch
from
January 11, 2022 17:06
7382c53
to
d645c5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
resolves #7891
Proposed Changes
disable mark-for-upgrade CLI 2 days before the network v15 upgrade epoch to avoid carrying over an old cc upgrade across the upgrades.
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <#issue number> <area>: <change being made>
fix: #1234 mempool: Introduce a cache for valid signatures
PR type
: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs, misc,perf, refactor, revert, style, testarea
: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet