Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: #7891 sectors: disable existing existing cc upgrade path 2 days before the upgrade epoch #7900

Merged
merged 9 commits into from
Jan 11, 2022

Conversation

jennijuju
Copy link
Member

@jennijuju jennijuju commented Jan 7, 2022

Related Issues

resolves #7891

Proposed Changes

disable mark-for-upgrade CLI 2 days before the network v15 upgrade epoch to avoid carrying over an old cc upgrade across the upgrades.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <#issue number> <area>: <change being made>
    • example: fix: #1234 mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs, misc,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

ZenGround0 and others added 4 commits January 5, 2022 03:10
- FSM handles the actual cc upgrade process including error states
- PoSting (winning and window) works over upgraded and upgrading sectors
- Integration test and changes to itest framework to reduce flakes
- Update CLI to handle new upgrade
- Update dependencies
…de to avoid unexpected edge cases that may cause deal/sector failure
@jennijuju jennijuju requested a review from a team as a code owner January 7, 2022 23:08
@jennijuju jennijuju changed the title Disable mark-for-upgrade two days before the network v15 OhSnap Upgrade enhancement: #7891 sectors: disable existing existing cc upgrade path 2 days before the upgrade epoch Jan 7, 2022
@jennijuju jennijuju added this to the v1.14.0 milestone Jan 10, 2022
@@ -1546,6 +1549,18 @@ var sectorsMarkForUpgradeCmd = &cli.Command{
if nv >= network.Version15 {
return xerrors.Errorf("classic cc upgrades disabled v15 and beyond, use `snap-up`")
}

// disable mark for upgrade two days before the ntwk v15 upgrade
// TODO: remove the following block in v1.15.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the entire mechanism will be removed in 1.15.1

Base automatically changed from feat/snap-deals to master January 11, 2022 17:46
@arajasek arajasek merged commit f87d8d0 into master Jan 11, 2022
@arajasek arajasek deleted the 7891 branch January 11, 2022 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable mark-for-upgrade 2 epoch days before the network upgrade
3 participants