Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #6147: Include worker name in sealing errors #7844

Merged

Conversation

llifezou
Copy link
Contributor

@llifezou llifezou commented Dec 23, 2021

Related Issues

#6147

Additional Info

When a sector is executed incorrectly(delete sc-02-data-layer-2.dat and produce an error), can see which worker name (hostname) executed it in lotus-miner sectors status --log:

SectorID:	2
Status:		ComputeProofFailed
CIDcommD:	baga6ea4seaqpy7usqklokfx2vxuynmupslkeutzexe2uqurdg5vhtebhxqmpqmy
CIDcommR:	bagboea4b5abcaanfg4ensvrat6mxojxn3v6qhvar5xayh7jv2ca3a3h777xwzall
Ticket:		7759ed6454fdf1a162971fb98343c0e88f09c581a09865f515207255f0155e8c
TicketH:	-852
Seed:		fe0a25949d1f48cce6c213895d60cca2fb5460f32c2cc3202bb44e8ef8e6604f
SeedH:		123
Precommit:	bafy2bzacebgaxlgralo4ypndahpsdllgd7ublxdk7hdd4mbtwz5r7yc62paqa
Commit:		<nil>
Deals:		[0]
Retries:	0
--------
Event Log:
0.	2021-12-23 17:27:05 +0800 CST:	[event;sealing.SectorStartCC]	{"User":{"ID":2,"SectorType":5}}
1.	2021-12-23 17:27:05 +0800 CST:	[event;sealing.SectorPacked]	{"User":{"FillerPieces":[{"Size":2048,"PieceCID":{"/":"baga6ea4seaqpy7usqklokfx2vxuynmupslkeutzexe2uqurdg5vhtebhxqmpqmy"}}]}}
2.	2021-12-23 17:27:05 +0800 CST:	[event;sealing.SectorTicket]	{"User":{"TicketValue":"d1ntZFT98aFilx+5g0PA6I8JxYGgmGX1FSByVfAVXow=","TicketEpoch":-852}}
3.	2021-12-23 17:27:05 +0800 CST:	[event;sealing.SectorPreCommit1]	{"User":{"PreCommit1Out":"eyJyZWdpc3RlcmVkX3Byb29mIjoiU3RhY2tlZERyZzJLaUJWMV8xIiwibGFiZWxzIjp7IlN0YWNrZWREcmcyS2lCVjEiOnsibGFiZWxzIjpbeyJwYXRoIjoiL2hvbWUvem91L3pvdS9maWxlY29pbi9kYXRhL2xvdHVzLXdvcmtlci9jYWNoZS9zLXQwMTAwMC0yIiwiaWQiOiJsYXllci0xIiwic2l6ZSI6NjQsInJvd3NfdG9fZGlzY2FyZCI6NX0seyJwYXRoIjoiL2hvbWUvem91L3pvdS9maWxlY29pbi9kYXRhL2xvdHVzLXdvcmtlci9jYWNoZS9zLXQwMTAwMC0yIiwiaWQiOiJsYXllci0yIiwic2l6ZSI6NjQsInJvd3NfdG9fZGlzY2FyZCI6NX1dLCJfaCI6bnVsbH19LCJjb25maWciOnsicGF0aCI6Ii9ob21lL3pvdS96b3UvZmlsZWNvaW4vZGF0YS9sb3R1cy13b3JrZXIvY2FjaGUvcy10MDEwMDAtMiIsImlkIjoidHJlZS1kIiwic2l6ZSI6MTI3LCJyb3dzX3RvX2Rpc2NhcmQiOjV9LCJjb21tX2QiOlsyNTIsMTI2LDE0NiwxMzAsMTUwLDIyOSwyMiwyNTAsMTczLDIzMywxMzQsMTc4LDE0MywxNDYsMjEyLDc0LDc5LDM2LDE4NSw1Myw3Miw4MiwzNSw1NSwxMDYsMTIxLDE0NCwzOSwxODgsMjQsMjQ4LDUxXX0="}}
4.	2021-12-23 17:27:05 +0800 CST:	[event;sealing.SectorPreCommit2]	{"User":{"Sealed":{"/":"bagboea4b5abcaanfg4ensvrat6mxojxn3v6qhvar5xayh7jv2ca3a3h777xwzall"},"Unsealed":{"/":"baga6ea4seaqpy7usqklokfx2vxuynmupslkeutzexe2uqurdg5vhtebhxqmpqmy"}}}
5.	2021-12-23 17:27:05 +0800 CST:	[event;sealing.SectorPreCommitBatch]	{"User":{}}
6.	2021-12-23 17:31:31 +0800 CST:	[event;sealing.SectorPreCommitBatchSent]	{"User":{"Message":{"/":"bafy2bzacebgaxlgralo4ypndahpsdllgd7ublxdk7hdd4mbtwz5r7yc62paqa"}}}
7.	2021-12-23 17:31:55 +0800 CST:	[event;sealing.SectorPreCommitLanded]	{"User":{"TipSet":"AXGg5AIgtHfL/D59ZRmk/g3044OnrY3WOkfORcYaU6gifTh7TnQ="}}
8.	2021-12-23 17:32:35 +0800 CST:	[event;sealing.SectorSeedReady]	{"User":{"SeedValue":"/gollJ0fSMzmwhOJXWDMovtUYPMsLMMgK7ROjvjmYE8=","SeedEpoch":123}}
9.	2021-12-23 17:32:36 +0800 CST:	[event;sealing.SectorComputeProofFailed]	{"User":{}}
	computing seal proof failed(1): storage call error 0: StandaloneSealCommit: Missing store file (or associated split paths): /home/zou/filecoin/data/lotus-worker/cache/s-t01000-2/sc-02-data-layer-2.dat [Hostname: llife]

@llifezou llifezou requested a review from a team as a code owner December 23, 2021 09:51
@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #7844 (4b685c5) into master (921fda9) will decrease coverage by 0.04%.
The diff coverage is 20.00%.

❗ Current head 4b685c5 differs from pull request most recent head dac5518. Consider uploading reports for the commit dac5518 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7844      +/-   ##
==========================================
- Coverage   39.46%   39.41%   -0.05%     
==========================================
  Files         654      654              
  Lines       70170    70179       +9     
==========================================
- Hits        27690    27659      -31     
- Misses      37727    37761      +34     
- Partials     4753     4759       +6     
Impacted Files Coverage Δ
extern/sector-storage/worker_local.go 59.46% <20.00%> (-1.33%) ⬇️
markets/loggers/loggers.go 89.28% <0.00%> (-10.72%) ⬇️
cli/util.go 41.66% <0.00%> (-8.34%) ⬇️
markets/retrievaladapter/client_blockstore.go 62.50% <0.00%> (-6.25%) ⬇️
chain/actors/builtin/miner/diff.go 52.94% <0.00%> (-5.89%) ⬇️
chain/stmgr/execute.go 86.95% <0.00%> (-4.35%) ⬇️
chain/types/tipset_key.go 85.96% <0.00%> (-3.51%) ⬇️
chain/sub/incoming.go 54.43% <0.00%> (-3.38%) ⬇️
extern/sector-storage/sched.go 83.12% <0.00%> (-2.47%) ⬇️
chain/stmgr/searchwait.go 66.02% <0.00%> (-1.29%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 921fda9...dac5518. Read the comment docs.

@llifezou llifezou changed the title Include worker name in sealing errors #6147 Include worker name in sealing errors Dec 23, 2021
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just one comment.

extern/sector-storage/worker_local.go Outdated Show resolved Hide resolved
Co-authored-by: Łukasz Magiera <magik6k@users.noreply.github.com>
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really useful. Thanks!

@magik6k magik6k changed the title #6147 Include worker name in sealing errors feat: #6147: Include worker name in sealing errors Mar 2, 2022
@magik6k magik6k merged commit a6892f9 into filecoin-project:master Mar 2, 2022
@silvianetobessa
Copy link

Hello @llifezou!

This contribution to the Filecoin codebase was voted as impactful during Q1 and is eligible for a FIL prize as part of a Protocol Labs experiment to reward open source contributions from the community (see full details here).

Please reach out to us through commons@protocol.ai to receive the instructions on how to claim your reward!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants