sectors update-state checks if sector exists before changing its state #7762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haven't been able to test yet. Will get to it Sunday. Current approach will not allow state update for sectors in |
Codecov Report
@@ Coverage Diff @@
## master #7762 +/- ##
==========================================
- Coverage 39.57% 39.55% -0.03%
==========================================
Files 640 640
Lines 68468 68471 +3
==========================================
- Hits 27095 27081 -14
- Misses 36722 36734 +12
- Partials 4651 4656 +5
Continue to review full report at Codecov.
|
arajasek
approved these changes
Dec 16, 2021
cmd/lotus-miner/sectors.go
Outdated
| } | ||
| } | ||
| if !sectorExists { | ||
| return xerrors.Errorf("sector %s not found, could not change state", cctx.Args().Get(0)) |
There was a problem hiding this comment.
Suggested change
| return xerrors.Errorf("sector %s not found, could not change state", cctx.Args().Get(0)) | |
| return xerrors.Errorf("sector %d not found, could not change state", id) |
Suggested change
| return xerrors.Errorf("sector %s not found, could not change state", cctx.Args().Get(0)) | |
| return xerrors.Errorf("sector %s not found, could not change state", cctx.Args().Get(0)) |
cmd/lotus-miner/sectors.go
Outdated
| return xerrors.Errorf("could not get list of sectors: %w", err) | ||
| } | ||
| var sectorExists = false | ||
| for _, x := range list { |
There was a problem hiding this comment.
nit: this variable is usually called v for value
magik6k
reviewed
Dec 16, 2021
cmd/lotus-miner/sectors.go
Outdated
| @@ -1648,6 +1648,21 @@ var sectorsUpdateCmd = &cli.Command{ | |||
| return xerrors.Errorf("could not parse sector number: %w", err) | |||
| } | |||
|
|
|||
| list, err := nodeApi.SectorsList(ctx) | |||
There was a problem hiding this comment.
Why not SectorsStatus? Getting a full list will be somewhat slow for bigger miners.
ff3958b to
27e48d7
Compare
arajasek
approved these changes
Dec 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #7754