Feat/sector storage unseal #7730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3757800 to
dcd348a
Compare
Codecov Report
@@ Coverage Diff @@
## next #7730 +/- ##
==========================================
+ Coverage 39.55% 39.59% +0.04%
==========================================
Files 646 646
Lines 68606 68687 +81
==========================================
+ Hits 27137 27197 +60
- Misses 36784 36795 +11
- Partials 4685 4695 +10
Continue to review full report at Codecov.
|
magik6k
reviewed
Dec 3, 2021
Comment on lines
+621
to
+624
| // NOTE: We set allowFetch to false in so that we always execute on a worker | ||
| // with direct access to the data. We want to do that because this step is | ||
| // generally very cheap / fast, and transferring data is not worth the effort | ||
| selector := newExistingSelector(m.index, sector.ID, storiface.FTUnsealed|storiface.FTUpdate|storiface.FTUpdateCache|storiface.FTCache, true) |
There was a problem hiding this comment.
Do we have benchmarks on how fast this is?
There was a problem hiding this comment.
Good idea. I'll add some basic benchmarking to the unit test so that @cryptonemo can generate a report on the big sectors.
- Unsealing replica update with sector key works and tested - Sector key generation added and tested
1978317 to
a5be808
Compare
magik6k
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends sector-storage to do unseal with snap deals replicas (+sector key) and to do sector key generation with snap deals replicas (+ unsealed data)
The snap deals test is extended to exercise both unsealing of data in a snap deals replica and removing and regenerating the sector key.