Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate v7 actors #7617

Merged
merged 6 commits into from
Nov 19, 2021
Merged

Integrate v7 actors #7617

merged 6 commits into from
Nov 19, 2021

Conversation

arajasek
Copy link
Contributor

Draft skeleton, basically does all the v7 integration except for FFI call for verification.

Blocked by actors work getting in (filecoin-project/specs-actors#1529)

@arajasek
Copy link
Contributor Author

Needs to be changed to a next or some such branch.

Or we can just land in master with an upgrade epoch set to after the rapture.

@arajasek arajasek changed the base branch from master to next November 17, 2021 00:10
@arajasek arajasek marked this pull request as ready for review November 17, 2021 01:48
@arajasek arajasek requested a review from a team as a code owner November 17, 2021 01:48
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly some notes/nits

Also, wdpost test is unhappy (doesn't seem to be flaky, restarting didn't help)

chain/consensus/filcns/upgrades.go Outdated Show resolved Hide resolved
chain/vm/gas_v0.go Show resolved Hide resolved
extern/sector-storage/ffiwrapper/verifier_cgo.go Outdated Show resolved Hide resolved
extern/sector-storage/mock/mock.go Outdated Show resolved Hide resolved
itests/ccupgrade_test.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #7617 (5f1783c) into next (e196a81) will decrease coverage by 0.43%.
The diff coverage is 56.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #7617      +/-   ##
==========================================
- Coverage   39.84%   39.40%   -0.44%     
==========================================
  Files         633      646      +13     
  Lines       67258    68376    +1118     
==========================================
+ Hits        26796    26945     +149     
- Misses      35874    36782     +908     
- Partials     4588     4649      +61     
Impacted Files Coverage Δ
build/params_mainnet.go 71.42% <0.00%> (ø)
build/params_shared_vals.go 71.42% <ø> (ø)
chain/gen/gen.go 68.19% <0.00%> (-1.04%) ⬇️
chain/vm/invoker.go 63.88% <ø> (ø)
chain/vm/runtime.go 54.20% <ø> (-0.87%) ⬇️
cmd/lotus-bench/caching_verifier.go 0.00% <0.00%> (ø)
cmd/lotus-sim/simulation/mock/mock.go 0.00% <0.00%> (ø)
extern/sector-storage/ffiwrapper/verifier_cgo.go 72.72% <0.00%> (-1.94%) ⬇️
extern/sector-storage/mock/mock.go 64.39% <0.00%> (-0.99%) ⬇️
chain/vm/syscalls.go 35.76% <6.25%> (-3.13%) ⬇️
... and 91 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e196a81...5f1783c. Read the comment docs.

@arajasek
Copy link
Contributor Author

This is now complete, good to merge after review

chain/actors/builtin/miner/v7.go Outdated Show resolved Hide resolved
chain/actors/builtin/miner/v7.go Outdated Show resolved Hide resolved
chain/actors/builtin/miner/v7.go Show resolved Hide resolved
chain/vm/runtime.go Show resolved Hide resolved
chain/vm/syscalls.go Show resolved Hide resolved
itests/wdpost_test.go Outdated Show resolved Hide resolved
@arajasek arajasek merged commit 9d44893 into next Nov 19, 2021
@arajasek arajasek deleted the asr/v7-actors branch November 19, 2021 20:25
@jennijuju jennijuju modified the milestones: SnapDeals, v1.14.0 Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants