Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkCommit should return SectorCommitFailed #7555

Merged
merged 1 commit into from Nov 22, 2021
Merged

checkCommit should return SectorCommitFailed #7555

merged 1 commit into from Nov 22, 2021

Conversation

yhio
Copy link
Contributor

@yhio yhio commented Oct 25, 2021

No description provided.

@yhio yhio requested a review from a team as a code owner October 25, 2021 03:02
@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #7555 (3123400) into master (e1deed3) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7555      +/-   ##
==========================================
- Coverage   39.89%   39.83%   -0.07%     
==========================================
  Files         633      633              
  Lines       67098    67098              
==========================================
- Hits        26769    26727      -42     
- Misses      35732    35771      +39     
- Partials     4597     4600       +3     
Impacted Files Coverage Δ
extern/storage-sealing/states_sealing.go 38.04% <0.00%> (ø)
storage/wdpost_sched.go 77.22% <0.00%> (-7.93%) ⬇️
extern/sector-storage/manager_calltracker.go 57.70% <0.00%> (-4.85%) ⬇️
miner/miner.go 54.96% <0.00%> (-3.65%) ⬇️
extern/storage-sealing/fsm.go 55.77% <0.00%> (-2.79%) ⬇️
chain/stmgr/searchwait.go 66.02% <0.00%> (-1.29%) ⬇️
chain/store/store.go 63.83% <0.00%> (-1.01%) ⬇️
storage/wdpost_run.go 69.62% <0.00%> (-0.64%) ⬇️
storage/wdpost_changehandler.go 97.64% <0.00%> (-0.48%) ⬇️
chain/consensus/filcns/filecoin.go 51.66% <0.00%> (-0.45%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1deed3...3123400. Read the comment docs.

@magik6k
Copy link
Contributor

magik6k commented Nov 22, 2021

(we should eventually just drop the ComputeProofFailed state)

@magik6k magik6k merged commit 2620eab into filecoin-project:master Nov 22, 2021
@yhio yhio deleted the dc/check-commit branch November 23, 2021 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants