-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.12.0-rc2 #7480
v1.12.0-rc2 #7480
Conversation
Codecov Report
@@ Coverage Diff @@
## release/v1.12.0 #7480 +/- ##
===================================================
+ Coverage 38.76% 39.33% +0.57%
===================================================
Files 627 627
Lines 66362 66373 +11
===================================================
+ Hits 25724 26110 +386
+ Misses 36171 35747 -424
- Partials 4467 4516 +49
Continue to review full report at Codecov.
|
// ??? | ||
var UpgradeChocolateHeight = abi.ChainEpoch(999999999) | ||
// 2021-10-26T13:30:00Z | ||
var UpgradeChocolateHeight = abi.ChainEpoch(1231620) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't check exactly but its in the right range of oct 25-26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirmed time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirmed as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with nits
// ??? | ||
var UpgradeChocolateHeight = abi.ChainEpoch(999999999) | ||
// 2021-10-26T13:30:00Z | ||
var UpgradeChocolateHeight = abi.ChainEpoch(1231620) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirmed time
03a8661
to
67b982d
Compare
67b982d
to
23c6597
Compare
Co-authored-by: Jiaying Wang <42981373+jennijuju@users.noreply.github.com>
Co-authored-by: Jiaying Wang <42981373+jennijuju@users.noreply.github.com>
Co-authored-by: Jiaying Wang <42981373+jennijuju@users.noreply.github.com>
Co-authored-by: Jiaying Wang <42981373+jennijuju@users.noreply.github.com>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
| Steve Loeppky | 1 | +6/-0 | 1 | | ||
| @ZenGround0 | 12 | +4202/-2752 | 187 | | ||
| @arajasek | 25 | +4567/-854 | 190 | | ||
| @laudiacay | 4 | +1276/-435 | 37 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
laudiacay shows up twice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| c r | 4 | +1276/-435 | 37 |
| Claudia Richoux | 12 | +1350/-209 | 43 |
our script thinks shes a double agent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am the double agent!!!
( you need a file with lines like this: https://github.com/ipfs/go-ipfs/blob/master/.mailmap#L92 )
No description provided.