Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.12.0-rc2 #7480

Merged
merged 14 commits into from
Oct 11, 2021
Merged

v1.12.0-rc2 #7480

merged 14 commits into from
Oct 11, 2021

Conversation

jennijuju
Copy link
Member

No description provided.

@jennijuju jennijuju requested a review from a team as a code owner October 8, 2021 19:16
@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #7480 (16743a2) into release/v1.12.0 (41be8fc) will increase coverage by 0.57%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v1.12.0    #7480      +/-   ##
===================================================
+ Coverage            38.76%   39.33%   +0.57%     
===================================================
  Files                  627      627              
  Lines                66362    66373      +11     
===================================================
+ Hits                 25724    26110     +386     
+ Misses               36171    35747     -424     
- Partials              4467     4516      +49     
Impacted Files Coverage Δ
build/params_mainnet.go 71.42% <ø> (ø)
build/params_shared_vals.go 71.42% <ø> (ø)
build/version.go 25.00% <ø> (ø)
chain/stmgr/stmgr.go 66.48% <ø> (+0.72%) ⬆️
cli/wallet.go 0.00% <0.00%> (ø)
cmd/lotus-miner/actor.go 7.87% <0.00%> (-0.07%) ⬇️
cmd/lotus-shed/actor.go 0.00% <0.00%> (ø)
chain/actors/builtin/multisig/message5.go 0.00% <0.00%> (-65.52%) ⬇️
chain/actors/builtin/paych/message5.go 28.88% <0.00%> (-57.78%) ⬇️
chain/actors/builtin/multisig/v5.go 23.63% <0.00%> (-40.00%) ⬇️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41be8fc...16743a2. Read the comment docs.

// ???
var UpgradeChocolateHeight = abi.ChainEpoch(999999999)
// 2021-10-26T13:30:00Z
var UpgradeChocolateHeight = abi.ChainEpoch(1231620)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't check exactly but its in the right range of oct 25-26

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed time

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed as well

go.mod Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with nits

CHANGELOG.md Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
// ???
var UpgradeChocolateHeight = abi.ChainEpoch(999999999)
// 2021-10-26T13:30:00Z
var UpgradeChocolateHeight = abi.ChainEpoch(1231620)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed time

CHANGELOG.md Outdated Show resolved Hide resolved
@jennijuju jennijuju force-pushed the jen/v1.12.0-rc2-prep branch from 03a8661 to 67b982d Compare October 11, 2021 11:50
@jennijuju jennijuju force-pushed the jen/v1.12.0-rc2-prep branch from 67b982d to 23c6597 Compare October 11, 2021 12:03
arajasek and others added 7 commits October 11, 2021 08:23
Co-authored-by: Jiaying Wang <42981373+jennijuju@users.noreply.github.com>
Co-authored-by: Jiaying Wang <42981373+jennijuju@users.noreply.github.com>
Co-authored-by: Jiaying Wang <42981373+jennijuju@users.noreply.github.com>
Co-authored-by: Jiaying Wang <42981373+jennijuju@users.noreply.github.com>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
@jennijuju jennijuju marked this pull request as draft October 11, 2021 12:26
@jennijuju jennijuju marked this pull request as ready for review October 11, 2021 12:53
cmd/lotus-miner/actor.go Outdated Show resolved Hide resolved
| Steve Loeppky | 1 | +6/-0 | 1 |
| @ZenGround0 | 12 | +4202/-2752 | 187 |
| @arajasek | 25 | +4567/-854 | 190 |
| @laudiacay | 4 | +1276/-435 | 37 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

laudiacay shows up twice

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

| c r | 4 | +1276/-435 | 37 |
| Claudia Richoux | 12 | +1350/-209 | 43 |

our script thinks shes a double agent

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am the double agent!!!

( you need a file with lines like this: https://github.com/ipfs/go-ipfs/blob/master/.mailmap#L92 )

@jennijuju jennijuju merged commit 6e61431 into release/v1.12.0 Oct 11, 2021
@jennijuju jennijuju deleted the jen/v1.12.0-rc2-prep branch October 11, 2021 16:57
jennijuju added a commit that referenced this pull request Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants