Fix Drand fetching around null tipsets #7376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
commented
Sep 22, 2021
arajasek
commented
Sep 22, 2021
| @@ -1037,81 +1035,6 @@ func TestSyncCheckpointEarlierThanHead(t *testing.T) { | |||
| require.True(tu.t, p1Head.Equals(b.TipSet())) | |||
| } | |||
|
|
|||
| func TestDrandNull(t *testing.T) { | |||
There was a problem hiding this comment.
This test was pretty bad...better test in rand_test now that also covers this case
4df6157 to
9773391
Compare
Codecov Report
@@ Coverage Diff @@
## feat/nv14 #7376 +/- ##
=============================================
- Coverage 39.29% 39.22% -0.07%
=============================================
Files 627 627
Lines 66099 66129 +30
=============================================
- Hits 25971 25940 -31
- Misses 35643 35706 +63
+ Partials 4485 4483 -2
Continue to review full report at Codecov.
|
9773391 to
76da461
Compare
Kubuxu
reviewed
Sep 27, 2021
chain/store/rand.go
Outdated
| func (cs *ChainStore) ExtractBeaconEntryForRound(ts *types.TipSet, round uint64) (*types.BeaconEntry, error) { | ||
| cbe := ts.Blocks()[0].BeaconEntries | ||
| for _, v := range cbe { | ||
| if v.Round == round { |
There was a problem hiding this comment.
You are passing ChainEpoch as round and comparing it with Drand round.
d3652f0 to
21bb0e7
Compare
arajasek
commented
Sep 29, 2021
| return cs.LoadTipSet(tsk) | ||
| } | ||
|
|
||
| func (cs *ChainStore) GetLatestBeaconEntry(ts *types.TipSet) (*types.BeaconEntry, error) { |
There was a problem hiding this comment.
This could be in the new stateRand instead, doesn't really make a difference
95f1fa9 to
6cedfbb
Compare
Kubuxu
approved these changes
Sep 29, 2021
6cedfbb to
c3c46e9
Compare
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3613