Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enforce verification key integrity check regardless of TRUST_PARAMS=1 #7327

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

placer14
Copy link
Contributor

closes #6640

See change in filecoin-project/go-paramfetch#17 for details.

@placer14 placer14 force-pushed the mg/feat/check-params-on-start branch from ef9116a to b7dfbc0 Compare September 13, 2021 22:39
@placer14
Copy link
Contributor Author

placer14 commented Sep 13, 2021

Please check that I did the module dependency dance properly. A go mod tidy seemed to reverse the update to go-fetchparam which was not what I expected (as it is neither unused or missing).

Edit: Nevermind. CI led me to salvation with a handy go mod download <package> which seemed to make it "formally used".

@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #7327 (b681078) into master (aab42dd) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7327      +/-   ##
==========================================
- Coverage   39.14%   39.13%   -0.01%     
==========================================
  Files         614      614              
  Lines       64997    64997              
==========================================
- Hits        25440    25436       -4     
- Misses      35143    35155      +12     
+ Partials     4414     4406       -8     
Impacted Files Coverage Δ
markets/loggers/loggers.go 89.28% <0.00%> (-10.72%) ⬇️
chain/actors/builtin/miner/diff.go 48.52% <0.00%> (-10.30%) ⬇️
chain/events/observer.go 71.64% <0.00%> (-6.72%) ⬇️
chain/stmgr/execute.go 86.95% <0.00%> (-4.35%) ⬇️
node/hello/hello.go 63.63% <0.00%> (-3.41%) ⬇️
extern/storage-sealing/fsm.go 56.22% <0.00%> (-1.21%) ⬇️
extern/sector-storage/sched_worker.go 77.97% <0.00%> (-0.73%) ⬇️
chain/store/store.go 64.37% <0.00%> (-0.71%) ⬇️
node/impl/full/chain.go 14.16% <0.00%> (-0.58%) ⬇️
chain/consensus/filcns/filecoin.go 51.33% <0.00%> (-0.45%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aab42dd...b681078. Read the comment docs.

@placer14 placer14 marked this pull request as ready for review September 13, 2021 22:56
@placer14 placer14 requested a review from a team as a code owner September 13, 2021 22:56
@placer14 placer14 changed the title fix: Update latest go-paramfetch fix: Enforce verification key integrity check regardless of TRUST_PARAMS=1 Sep 14, 2021
@placer14 placer14 marked this pull request as draft September 14, 2021 13:22
@placer14
Copy link
Contributor Author

Holding this PR as I now realize the dependent package could be squash-merged causing the commit SHA to change. I'll ready this again once the dependent PR is merged and SHA updated.

go.mod Outdated Show resolved Hide resolved
@placer14 placer14 force-pushed the mg/feat/check-params-on-start branch 2 times, most recently from 26ec4ac to 859ae64 Compare September 14, 2021 15:49
@placer14 placer14 force-pushed the mg/feat/check-params-on-start branch from 859ae64 to b681078 Compare September 14, 2021 16:09
@placer14 placer14 marked this pull request as ready for review September 14, 2021 16:10
@placer14 placer14 requested a review from magik6k September 14, 2021 16:10
@magik6k magik6k merged commit 4fc78bf into master Sep 15, 2021
@magik6k magik6k deleted the mg/feat/check-params-on-start branch September 15, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] lotus daemon should refuse to run unless all verification params are present
2 participants