-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mempool msg selection should respect block message limits #7321
Conversation
4a1eadb
to
f5a315a
Compare
Codecov Report
@@ Coverage Diff @@
## master #7321 +/- ##
==========================================
+ Coverage 39.54% 39.59% +0.04%
==========================================
Files 640 640
Lines 68469 68496 +27
==========================================
+ Hits 27076 27119 +43
+ Misses 36742 36721 -21
- Partials 4651 4656 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ugh, this looks ugly... not passing judgement yet though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM, 1 nit
|
||
// one last sanity check | ||
if len(sm.msgs) > build.BlockMessageLimit { | ||
sm.msgs = sm.msgs[:build.BlockMessageLimit] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Log warning or error because this means that the code is wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yessir!
f5a315a
to
a45803d
Compare
No description provided.