Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mempool msg selection should respect block message limits #7321

Merged
merged 5 commits into from
Dec 17, 2021

Conversation

arajasek
Copy link
Contributor

No description provided.

@arajasek arajasek requested a review from a team as a code owner September 12, 2021 23:38
@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #7321 (b08bf32) into master (dc26f3b) will increase coverage by 0.04%.
The diff coverage is 78.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7321      +/-   ##
==========================================
+ Coverage   39.54%   39.59%   +0.04%     
==========================================
  Files         640      640              
  Lines       68469    68496      +27     
==========================================
+ Hits        27076    27119      +43     
+ Misses      36742    36721      -21     
- Partials     4651     4656       +5     
Impacted Files Coverage Δ
chain/messagepool/repub.go 55.91% <0.00%> (+3.16%) ⬆️
chain/consensus/filcns/mine.go 64.28% <33.33%> (-1.57%) ⬇️
chain/messagepool/selection.go 83.52% <81.74%> (+2.99%) ⬆️
chain/exchange/peer_tracker.go 66.66% <0.00%> (-4.31%) ⬇️
markets/storageadapter/ondealsectorcommitted.go 77.33% <0.00%> (-4.00%) ⬇️
storage/wdpost_sched.go 79.41% <0.00%> (-1.97%) ⬇️
extern/sector-storage/sched_worker.go 77.90% <0.00%> (-1.75%) ⬇️
extern/sector-storage/sched.go 83.12% <0.00%> (-1.65%) ⬇️
storage/wdpost_changehandler.go 97.64% <0.00%> (-0.95%) ⬇️
miner/miner.go 56.95% <0.00%> (-0.67%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc26f3b...b08bf32. Read the comment docs.

Copy link
Contributor

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh, this looks ugly... not passing judgement yet though.

@jennijuju jennijuju added this to the v1.13.1 milestone Oct 4, 2021
@jennijuju jennijuju added the P1 P1: Must be resolved label Oct 4, 2021
@jennijuju jennijuju requested review from Kubuxu and magik6k October 4, 2021 01:57
@jennijuju jennijuju modified the milestones: v1.13.1, v1.15.0 Dec 6, 2021
Copy link
Contributor

@Kubuxu Kubuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, 1 nit


// one last sanity check
if len(sm.msgs) > build.BlockMessageLimit {
sm.msgs = sm.msgs[:build.BlockMessageLimit]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log warning or error because this means that the code is wrong.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yessir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 P1: Must be resolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants