Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show deal sizes is sealing sectors #7261

Merged
merged 4 commits into from
Sep 7, 2021
Merged

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Sep 2, 2021

2021-09-02-214304_983x126_scrot

(review commit-by-commit)

@magik6k magik6k requested a review from a team as a code owner September 2, 2021 19:48
@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #7261 (dfc0392) into master (b089cc4) will decrease coverage by 0.02%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7261      +/-   ##
==========================================
- Coverage   39.14%   39.11%   -0.03%     
==========================================
  Files         614      614              
  Lines       64965    64983      +18     
==========================================
- Hits        25429    25419      -10     
- Misses      35135    35156      +21     
- Partials     4401     4408       +7     
Impacted Files Coverage Δ
api/api_storage.go 0.00% <ø> (ø)
cmd/lotus-miner/sectors.go 11.30% <36.25%> (+0.24%) ⬆️
storage/miner_sealing.go 85.88% <100.00%> (+0.88%) ⬆️
extern/sector-storage/sched_resources.go 75.00% <0.00%> (-9.38%) ⬇️
chain/actors/builtin/paych/paych.go 16.88% <0.00%> (-5.20%) ⬇️
chain/exchange/peer_tracker.go 66.66% <0.00%> (-4.31%) ⬇️
extern/sector-storage/manager_calltracker.go 59.03% <0.00%> (-3.53%) ⬇️
node/hello/hello.go 63.63% <0.00%> (-3.41%) ⬇️
extern/storage-sealing/fsm.go 56.22% <0.00%> (-2.82%) ⬇️
blockstore/buffered.go 40.00% <0.00%> (-2.23%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b089cc4...dfc0392. Read the comment docs.

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits but this seems like a reasonable refactor. But I haven't tested it so I'll leave that to you.

cmd/lotus-miner/sectors.go Outdated Show resolved Hide resolved
if !strings.HasPrefix(sectorLog.Kind, "event") {
continue
}
if sectorLog.Kind == "event;sealing.SectorRestart" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we avoid hard-coding?

@magik6k magik6k force-pushed the feat/sectors-list-sealing-deals branch from 03e2016 to dfc0392 Compare September 7, 2021 17:55
@magik6k magik6k enabled auto-merge September 7, 2021 17:56
@magik6k magik6k merged commit b7f771b into master Sep 7, 2021
@magik6k magik6k deleted the feat/sectors-list-sealing-deals branch September 7, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants