-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show deal sizes is sealing sectors #7261
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7261 +/- ##
==========================================
- Coverage 39.14% 39.11% -0.03%
==========================================
Files 614 614
Lines 64965 64983 +18
==========================================
- Hits 25429 25419 -10
- Misses 35135 35156 +21
- Partials 4401 4408 +7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two nits but this seems like a reasonable refactor. But I haven't tested it so I'll leave that to you.
if !strings.HasPrefix(sectorLog.Kind, "event") { | ||
continue | ||
} | ||
if sectorLog.Kind == "event;sealing.SectorRestart" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we avoid hard-coding?
03e2016
to
dfc0392
Compare
(review commit-by-commit)