Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stores: Fix reserved disk usage log spam #7233

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Aug 31, 2021

(also upgrade the log to Warn when we see real errors)

@magik6k magik6k requested a review from a team as a code owner August 31, 2021 11:38
@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

Merging #7233 (3118bd1) into master (b0f57d7) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7233      +/-   ##
==========================================
+ Coverage   39.10%   39.11%   +0.01%     
==========================================
  Files         610      610              
  Lines       64716    64717       +1     
==========================================
+ Hits        25305    25314       +9     
+ Misses      35021    35012       -9     
- Partials     4390     4391       +1     
Impacted Files Coverage Δ
extern/sector-storage/stores/local.go 58.80% <0.00%> (-0.46%) ⬇️
extern/sector-storage/sched_resources.go 75.00% <0.00%> (-9.38%) ⬇️
chain/sub/incoming.go 49.70% <0.00%> (-2.37%) ⬇️
storage/wdpost_sched.go 77.22% <0.00%> (-1.99%) ⬇️
itests/kit/blockminer.go 93.65% <0.00%> (-1.59%) ⬇️
storage/wdpost_changehandler.go 97.64% <0.00%> (-0.95%) ⬇️
storage/wdpost_run.go 69.62% <0.00%> (-0.64%) ⬇️
blockstore/badger/blockstore.go 57.28% <0.00%> (-0.41%) ⬇️
node/impl/full/state.go 34.22% <0.00%> (-0.25%) ⬇️
chain/sync.go 61.20% <0.00%> (-0.22%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0f57d7...3118bd1. Read the comment docs.

Copy link
Contributor

@ZenGround0 ZenGround0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@magik6k magik6k merged commit 4c607d9 into master Aug 31, 2021
@magik6k magik6k deleted the fix/storage-reserved-spam branch August 31, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants