-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: re-enable disabled tests #7211
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,7 +26,6 @@ func LoadVector(t *testing.T, f string, out interface{}) { | |
} | ||
|
||
func TestBlockHeaderVectors(t *testing.T) { | ||
t.Skip("we need to regenerate for beacon") | ||
var headers []HeaderVector | ||
LoadVector(t, "block_headers.json", &headers) | ||
|
||
|
@@ -65,8 +64,6 @@ func TestMessageSigningVectors(t *testing.T) { | |
} | ||
|
||
func TestUnsignedMessageVectors(t *testing.T) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Have the vectors been fixed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The tests pass. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Although I'm not seeing any updates. |
||
t.Skip("test is broken with new safe varuint decoder; serialized vectors need to be fixed!") | ||
|
||
var msvs []UnsignedMessageVector | ||
LoadVector(t, "unsigned_messages.json", &msvs) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we done the vector regeneration described here?
Do we even run vector tests any more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests pass.