Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: exclude cruft from code coverage #7189

Merged
merged 1 commit into from
Aug 26, 2021
Merged

ci: exclude cruft from code coverage #7189

merged 1 commit into from
Aug 26, 2021

Conversation

Stebalien
Copy link
Member

  1. Exclude generated code.
  2. Exclude generated actors, we mostly test against the latest version.

1. Exclude generated code.
2. Exclude generated actors, we mostly test against the latest version.
@Stebalien Stebalien requested a review from a team as a code owner August 26, 2021 19:41
@Stebalien Stebalien requested a review from ZenGround0 August 26, 2021 19:42
@Stebalien
Copy link
Member Author

E.g., see https://app.codecov.io/gh/filecoin-project/lotus/compare/7187/changes. We're getting 31 lines from the v2 actors.

@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #7189 (1cecf3c) into master (8bcd917) will increase coverage by 4.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7189      +/-   ##
==========================================
+ Coverage   34.84%   39.08%   +4.24%     
==========================================
  Files         688      607      -81     
  Lines       80386    64565   -15821     
==========================================
- Hits        28013    25238    -2775     
+ Misses      46672    34946   -11726     
+ Partials     5701     4381    -1320     
Impacted Files Coverage Δ
api/client/client.go 38.98% <0.00%> (-7.60%) ⬇️
chain/actors/builtin/paych/paych.go 16.88% <0.00%> (-5.20%) ⬇️
storage/wdpost_sched.go 77.22% <0.00%> (-3.97%) ⬇️
node/hello/hello.go 63.21% <0.00%> (-3.45%) ⬇️
chain/store/store.go 63.41% <0.00%> (-1.07%) ⬇️
extern/sector-storage/sched_worker.go 77.97% <0.00%> (-0.73%) ⬇️
chain/sync_manager.go 66.77% <0.00%> (-0.63%) ⬇️
cmd/tvx/stores.go 0.00% <0.00%> (ø)
storage/wdpost_changehandler.go 98.11% <0.00%> (ø)
extern/sector-storage/stores/local.go 59.25% <0.00%> (ø)
... and 92 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bcd917...1cecf3c. Read the comment docs.

@Stebalien Stebalien enabled auto-merge August 26, 2021 19:59
@Stebalien Stebalien merged commit c664f9e into master Aug 26, 2021
@Stebalien Stebalien deleted the ci/code-cov-ignore branch August 26, 2021 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants