Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make TestTimedCacheBlockstoreSimple pass reliably #7174

Merged
merged 2 commits into from
Aug 25, 2021

Conversation

Stebalien
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #7174 (b3966ab) into master (263a85c) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7174      +/-   ##
==========================================
- Coverage   34.85%   34.73%   -0.13%     
==========================================
  Files         684      684              
  Lines       80137    80137              
==========================================
- Hits        27934    27837      -97     
- Misses      46518    46632     +114     
+ Partials     5685     5668      -17     
Impacted Files Coverage Δ
blockstore/timed.go 67.00% <100.00%> (ø)
chain/actors/builtin/paych/v4.go 0.00% <0.00%> (-40.00%) ⬇️
chain/actors/builtin/paych/message4.go 0.00% <0.00%> (-28.89%) ⬇️
storage/addresses.go 55.95% <0.00%> (-8.34%) ⬇️
storage/wdpost_sched.go 77.22% <0.00%> (-7.93%) ⬇️
chain/actors/builtin/market/v4.go 36.52% <0.00%> (-7.83%) ⬇️
chain/actors/builtin/miner/v4.go 39.00% <0.00%> (-7.13%) ⬇️
chain/actors/builtin/paych/paych.go 16.88% <0.00%> (-5.20%) ⬇️
chain/stmgr/call.go 62.00% <0.00%> (-4.00%) ⬇️
blockstore/buffered.go 40.00% <0.00%> (-2.23%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 263a85c...b3966ab. Read the comment docs.

blockstore/timed.go Outdated Show resolved Hide resolved
@arajasek arajasek enabled auto-merge August 25, 2021 00:39
@Stebalien
Copy link
Member Author

codecov/project/miner — 68.33% (-0.69%) compared to 263a85c

🙄

@Stebalien Stebalien disabled auto-merge August 25, 2021 01:05
@Stebalien Stebalien merged commit 87fc8db into master Aug 25, 2021
@Stebalien Stebalien deleted the fix/timed-blockstore-test branch August 25, 2021 01:06
@Stebalien
Copy link
Member Author

CodeQL can stuff it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants