miner: Command to list/remove expired sectors #7140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20db281 to
a9bf246
Compare
|
Rebased to try to make CI green. |
Codecov Report
@@ Coverage Diff @@
## master #7140 +/- ##
==========================================
+ Coverage 34.78% 34.84% +0.05%
==========================================
Files 684 684
Lines 80040 80136 +96
==========================================
+ Hits 27845 27923 +78
- Misses 46522 46530 +8
- Partials 5673 5683 +10
Continue to review full report at Codecov.
|
arajasek
approved these changes
Aug 24, 2021
cmd/lotus-miner/sectors.go
Outdated
|
|
||
| // toCheck is a working bitfield which will only contain terminated sectors | ||
| toCheck := bitfield.New() | ||
| { |
There was a problem hiding this comment.
Just for my education what's the point of having code blocks like this?
There was a problem hiding this comment.
Generally just for not leaking variables into the wider function context (which makes it easier to see when we are done with those vars)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should make this automatic at some point, but this is at least a good tool to manage expired sectors
--show-removedoutput:The 'actually remove things' output:
