add explicit error msg if repo dir does not exist #6909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6b83d77 to
27eebba
Compare
magik6k
reviewed
Jul 28, 2021
cli/util/api.go
Outdated
| } | ||
|
|
||
| if !exists { | ||
| return APIInfo{}, errors.New("repo directory does not exist. Make sure your configuration is correct") |
There was a problem hiding this comment.
What do we print if you run lotus-miner init .. without a full-node repo? (just want to make sure we won't make that message really confusing)
There was a problem hiding this comment.
# repo dir doesn't exist
➜ LOTUS_PATH=~/.lotussss LOTUS_MINER_PATH=~/.restoredrepo ./lotus-miner init service --type=markets --api-sealer=$APISEALER --api-sector-index=$APISEALER --config=~/.lotusmarket/config.toml ~/.lotusbackup/backupfile
2021-07-29T14:54:08.146+0300 INFO main lotus-miner/init_service.go:54 Initializing lotus miner service
2021-07-29T14:54:08.147+0300 INFO main lotus-miner/init_restore.go:102 Trying to connect to full node RPC
ERROR: could not get API info: repo directory does not exist. Make sure your configuration is correct
# no LOTUS_PATH, so ~/.lotus is inferred and it just works
➜ LOTUS_MINER_PATH=~/.restoredrepo ./lotus-miner init service --type=markets --api-sealer=$APISEALER --api-sector-index=$APISEALER --config=~/.lotusmarket/config.toml ~/.lotusbackup/backupfile
# no LOTUS_PATH, but this time repo exists (so config is correct), but node is not running
➜ LOTUS_MINER_PATH=~/.restoredrepo ./lotus-miner init service --type=markets --api-sealer=$APISEALER --api-sector-index=$APISEALER --config=~/.lotusmarket/config.toml ~/.lotusbackup/backupfile
2021-07-29T14:57:18.953+0300 INFO main lotus-miner/init_service.go:54 Initializing lotus miner service
2021-07-29T14:57:18.953+0300 INFO main lotus-miner/init_restore.go:102 Trying to connect to full node RPC
ERROR: could not get API info: could not get api endpoint: API not running (no endpoint)
Kubuxu
approved these changes
Jul 30, 2021
ca38ec9 to
5b1fdb9
Compare
5b1fdb9 to
fa7e52d
Compare
|
Rebased and I’m gonna merge it and backport it in the v1.11.1 release branch so it’s in v1.11.1-rc2. Please open new prs if we need further improvements on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding an explicit error in case someone tries to run CLI pointed at incorrect repo location. We had a lot of confusion with this yesterday, given that miners are now running multiple miner instances on one host.