fix warmup by decoupling state from message receipt walk #6841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, tests forthcoming soon -- we have #6834 open. |
magik6k
reviewed
Jul 22, 2021
| @@ -631,14 +631,16 @@ func (s *SplitStore) endTxnProtect() { | |||
| s.txnMissing = nil | |||
| } | |||
|
|
|||
| func (s *SplitStore) walkChain(ts *types.TipSet, inclState abi.ChainEpoch, inclMsgs abi.ChainEpoch, | |||
| func (s *SplitStore) walkChain(ts *types.TipSet, inclState, inclMsgs, inclMsgReceipts abi.ChainEpoch, | |||
There was a problem hiding this comment.
Why separate height for receipts?
There was a problem hiding this comment.
well, I wanted to decouple it from state as it was the source of the bug -- when we sync from snapshot we dont have message receipts at all!
We could ostensibly couple them with the messages, but I don't think we need them at all in order to support the use cases -- please correct me if I am wrong :)
There was a problem hiding this comment.
following sync discussion, we discussed to collate them with message retention.
magik6k
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was accidentally broken in #6775.