ClientRetrieve stops on cancel #6739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a deal is cancelled, any in progress calls to ClientRetrieve or ClientRetrieveWithEvents should return
raulk
approved these changes
Jul 12, 2021
|
is it not bad go practice for errors to start with a capital letter? (i don't really know what i'm talking about) |
|
@arajasek I think it might be, and also, I seem to chafe against this cause I hate the idea of not using proper human grammar, so no matter how many times someone reminds me, I forget this rule. (unintentionally I swear) |
|
oOpSiE |
|
wOULD tHIS bE a vALID eRROR |
|
Just kidding :-) Agree we should settle on a rule and revisit all errors to comply with it. And that rule should probably be what's idiomatic (starts with lower case, doesn't end with punctuation) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
fix #6738
Implementation
Check for deal status cancelled when inspecting deal events in ClientRetrieve and ClientRetrieveWithEvents, and close channel when that happens.