Add ChainGetMessagesInTipset API #6642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build is unhappy, but I think this is a reasonable thing to add. |
11c2b17 to
6404794
Compare
magik6k
reviewed
Jul 5, 2021
There was a problem hiding this comment.
Looks good, but it would be really great to have a test for this.
https://github.com/filecoin-project/lotus/blob/master/itests/nonce_test.go is one of the tests which does some message sending, so it should be easy to write a new test based off it. (when writing itests, after creating a new file in the itests directory make sure to run make circleci to update the CI config)
|
Test awaiting @hunjixin |
|
@jennijuju done |
6f6fec1 to
d023026
Compare
|
@jennijuju update |
magik6k
approved these changes
Jul 15, 2021
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.