Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit and Precommit batcher cannot share a getSectorDeadline method #6416

Merged
merged 4 commits into from
Jun 9, 2021
Merged

Commit and Precommit batcher cannot share a getSectorDeadline method #6416

merged 4 commits into from
Jun 9, 2021

Conversation

arajasek
Copy link
Contributor

@arajasek arajasek commented Jun 8, 2021 •
edited
Loading

Fixes #6412

Two commits:

  • Rename "deadlines" as requested by @jennijuju to avoid confusion with window post deadlines
  • Split the getSectorCutoff methods between precommit and commit batchers

@arajasek arajasek requested a review from jennijuju June 8, 2021 00:23
@arajasek arajasek changed the title Asr/sector cutoffs Commit and Precommit batcher cannot share a getSectorDeadline method Jun 8, 2021
magik6k
magik6k reviewed Jun 8, 2021
View reviewed changes
extern/storage-sealing/types.go Outdated Show resolved Hide resolved
extern/storage-sealing/commit_batch.go Outdated Show resolved Hide resolved
@arajasek
Copy link
Contributor Author

arajasek commented Jun 8, 2021

@magik6k Yeah, makes sense. I'll make the CommitBatcher look up the height.

@BigLep BigLep linked an issue Jun 8, 2021 that may be closed by this pull request
CommitBatcher getSectorDeadline should check the earlier PreCommit expiry in the batch #6412
Closed
@arajasek arajasek force-pushed the asr/sector-cutoffs branch from 906c21a to 71909c5 Compare June 8, 2021 20:46
@BlocksOnAChain BlocksOnAChain added this to the Network Hyperdrive milestone Jun 9, 2021
@arajasek arajasek mentioned this pull request Jun 9, 2021
Merged
@magik6k magik6k merged commit f75922f into release/v1.10.0 Jun 9, 2021
@magik6k magik6k deleted the asr/sector-cutoffs branch June 9, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

@jennijuju jennijuju Awaiting requested review from jennijuju

Assignees

@arajasek arajasek

Labels
None yet
Projects
None yet
Milestone
Network Hyperdrive
Development

Successfully merging this pull request may close these issues.

CommitBatcher getSectorDeadline should check the earlier PreCommit expiry in the batch
4 participants
@arajasek @magik6k @jennijuju @BlocksOnAChain