introduce message prototypes #5893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces message prototypes to applicable API endpoints, which allows us to invert control of message sending and give the user a chance to intervene with an interactive ui.
…ion logic Otherwise the lotus-gateway msig tests are failing
MpoolCheck* return all checks, whether successful or not; that means we would always fail with ErrCheckFailed, which is _not_ what we want; we only want to fail if a check has failed.
8052516 to
89e634a
Compare
|
@arajasek this is quite unrelated. |
Kubuxu
reviewed
Mar 30, 2021
| var outChecks [][]api.MessageCheckStatus | ||
| checks, err := s.api.MpoolCheckMessages(ctx, []*types.Message{prototype}) | ||
| checks, err := s.api.MpoolCheckMessages(ctx, []*types.Message{&prototype.Message}) |
There was a problem hiding this comment.
I think it would be better to pass the prototype to MpoolCheckMessages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces message prototypes to applicable API endpoints, which
allows us to invert control of message sending and give the user a
chance to intervene with an interactive ui.