Storage Mining Module #587
Conversation
…mentations for MostRecentState (renamed from MostRecentStateId,) GetMinerState, GetRandomness and GetProvingPeriod.
…mentations for MostRecentState (renamed from MostRecentStateId,) GetMinerState, GetRandomness and GetProvingPeriod.
…Deal, SubmitDeclaredRecoveries and GetSealSeed. Improved state change notifications.
…ect/lotus into feat/storage-mining-module
2. Changed deals from []cid.Cid to []uint64 on SubmitSectorPreCommitment. 3. Added deals ([]uint64) to SubmitSectorCommitment.
|
Can a storage miner adapter multiple fullnode |
There was a problem hiding this comment.
Great progress.
Process-wise, I think you're trying to do slightly too much all at once. Scope this down to just the subscription mechanism and the straightforward Node methods, then let's fill out the rest in subsequent PRs. When this PR is ready for Lotus team review, it would ideally contain only working code.
The adapter needs tests. I'm not yet familiar with how to set up a unit test involving a full node (hopefully there's an in-process way to construct one). If there's not an obvious example lying around please ask lotus-dev directly (in public, so we can all learn).
No plan for a miner module to work with multiple nodes at present, though there should be no great barrier to operators implementing something like that. |
2. Added synchronization for event listeners. 3. Reading and returning the initial state when adapter is created.
2. Added actor address. 3. Removed epoch from GetRandomness as StateKey has implicit epoch. 4. Added unit tests for node creation, GetMinerState, GetProvingPeriod and GetRandomness.
2. Refactoring to reduce code duplication. 3. Implementation sketch for SubmitSelfDeals.
|
More test coverage is coming, as are self-deals. But this is ready for another look from @anorth and a first pass from @magik6k or @Kubuxu or @whyrusleeping. |
|
Closing this as abandoned |
What's in this PR?
Nodefunctionality needed by the storage mining module.Nodeinterface for Lotus.