Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): fetch tags #12679

Merged
merged 1 commit into from
Nov 7, 2024
Merged

fix(ci): fetch tags #12679

merged 1 commit into from
Nov 7, 2024

Conversation

Stebalien
Copy link
Member

Related Issues

Proposed Changes

By default the github checkout action fetches with depth 0 and no tags. By explicitly specifying depth 0, we'll get the tags. No, specifying fetch-tags doesn't work because that only applies to the root repo, not the submodules.

We need submoule tags to be able to fetch the pre-built FFI.

Checklist

Before you mark the PR ready for review, please make sure that:

We need submoule tags to be able to fetch the pre-built FFI.
@Stebalien
Copy link
Member Author

Already backported to #12678.

@Stebalien Stebalien requested a review from rjan90 November 7, 2024 03:04
Copy link
Contributor

@rjan90 rjan90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm that this change made the tests (Build node (macos-13) and Build miner (macos-13)) pass

@Stebalien Stebalien merged commit a4a7cbe into master Nov 7, 2024
82 of 83 checks passed
@Stebalien Stebalien deleted the steb/fetch-tags-ci branch November 7, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

3 participants