Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update actor code ID in lotus-shed invariant check #12572

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Oct 10, 2024

Related Issues

When running the invariant check after running a bench migration (./lotus-shed migrate-state --check-invariants=true ..) it failed with:

main.checkNv24Invariants
     /home/filoz/lotus/cmd/lotus-shed/migrations.go:649
  - unexpected actor code CID bafk2bzaceabq3zagn4ee2wbagarxf7xgbrqgqgm55xydanxik2bifztqgynts for address t094151:

This is because the checkNv24Invariants was wrongly set to Version 14 actors.

Proposed Changes

This PR updates actors.GetActorCodeIDs to Version 15 in the checkNv24Invariants function.

Checklist

Before you mark the PR ready for review, please make sure that:

…ts check

fix(migrations): update actor code IDs to Version15 for NV24 invariants check
@rjan90 rjan90 added release/backport skip/changelog This change does not require CHANGELOG.md update labels Oct 10, 2024
@rjan90 rjan90 merged commit 7192736 into master Oct 10, 2024
88 checks passed
@rjan90 rjan90 deleted the phi/fix-lotus-shed-migrations-cmd branch October 10, 2024 09:03
rjan90 added a commit that referenced this pull request Oct 14, 2024
…ts check (#12572)

fix(migrations): update actor code IDs to Version15 for NV24 invariants check
rjan90 added a commit that referenced this pull request Oct 14, 2024
…ts check (#12572)

fix(migrations): update actor code IDs to Version15 for NV24 invariants check
rjan90 added a commit that referenced this pull request Oct 14, 2024
…ts check (#12572)

fix(migrations): update actor code IDs to Version15 for NV24 invariants check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

2 participants