Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(libp2p): expose libp2p bandwidth metrics #12402

Merged
merged 6 commits into from
Aug 19, 2024
Merged

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Aug 16, 2024

Related Issues

Alternative to #12401
Resolves filecoin-project/go-f3#575

Proposed Changes

Exposes bandwidth metrics via opentelemetry. We do this via an async callback to avoid allocating/reporting metrics on any hot-paths. I'm using open telemetry as we've already setup a bridge for F3 and opencensus is deprecated in favor of open telemetry (so we're going to slowly move over anyways).

Checklist

Before you mark the PR ready for review, please make sure that:

@Stebalien Stebalien force-pushed the steb/bw-metrics-otel branch 2 times, most recently from 5f22c58 to 65040f0 Compare August 16, 2024 21:28
@Stebalien
Copy link
Member Author

This appears to have no perf impact, but I need to test again once the splitstore stops.

@Stebalien Stebalien force-pushed the steb/bw-metrics-otel branch from 65040f0 to 85739f6 Compare August 16, 2024 21:40
@Stebalien
Copy link
Member Author

@Kubuxu what do you think about this version? We should also talk about what we want in terms of otel conventions.

@Stebalien
Copy link
Member Author

Ok, there's definitely no performance impact from this version.

This exposes bandwidth metrics via async callback to avoid
allocating/reporting metrics on any hot-paths. I'm using open telemetry
as we've already setup a bridge for F3 and opencensus is deprecated in
favor of open telemetry (so we're going to slowly move over anyways).
@Stebalien Stebalien force-pushed the steb/bw-metrics-otel branch from 85739f6 to 40de26f Compare August 19, 2024 15:22
@Stebalien Stebalien requested a review from Kubuxu August 19, 2024 16:17
@Stebalien Stebalien merged commit dbef5de into master Aug 19, 2024
84 checks passed
@Stebalien Stebalien deleted the steb/bw-metrics-otel branch August 19, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose bandwidth traffic metrics in lotus
2 participants