-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(libp2p): expose libp2p bandwidth metrics #12402
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Stebalien
force-pushed
the
steb/bw-metrics-otel
branch
2 times, most recently
from
August 16, 2024 21:28
5f22c58
to
65040f0
Compare
This appears to have no perf impact, but I need to test again once the splitstore stops. |
Stebalien
force-pushed
the
steb/bw-metrics-otel
branch
from
August 16, 2024 21:40
65040f0
to
85739f6
Compare
@Kubuxu what do you think about this version? We should also talk about what we want in terms of otel conventions. |
Ok, there's definitely no performance impact from this version. |
Kubuxu
reviewed
Aug 19, 2024
Kubuxu
reviewed
Aug 19, 2024
This exposes bandwidth metrics via async callback to avoid allocating/reporting metrics on any hot-paths. I'm using open telemetry as we've already setup a bridge for F3 and opencensus is deprecated in favor of open telemetry (so we're going to slowly move over anyways).
Stebalien
force-pushed
the
steb/bw-metrics-otel
branch
from
August 19, 2024 15:22
85739f6
to
40de26f
Compare
Kubuxu
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Alternative to #12401
Resolves filecoin-project/go-f3#575
Proposed Changes
Exposes bandwidth metrics via opentelemetry. We do this via an async callback to avoid allocating/reporting metrics on any hot-paths. I'm using open telemetry as we've already setup a bridge for F3 and opencensus is deprecated in favor of open telemetry (so we're going to slowly move over anyways).
Checklist
Before you mark the PR ready for review, please make sure that: